Re: [PATCH v1 1/1] x86/platform/iosf_mbi: Remove duplicate definitions

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5365 bytes --]

Hi Andy,

[auto build test ERROR on thermal/next]
[also build test ERROR on v4.3 next-20151111]
[cannot apply to tip/x86/core]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/x86-platform-iosf_mbi-Remove-duplicate-definitions/20151112-002509
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   arch/x86/platform/intel-quark/imr.c: In function 'imr_read':
>> arch/x86/platform/intel-quark/imr.c:114:39: error: 'QRK_MBI_MM_READ' undeclared (first use in this function)
     ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
                                          ^
   arch/x86/platform/intel-quark/imr.c:114:39: note: each undeclared identifier is reported only once for each function it appears in
   arch/x86/platform/intel-quark/imr.c: In function 'imr_write':
>> arch/x86/platform/intel-quark/imr.c:154:40: error: 'QRK_MBI_MM_WRITE' undeclared (first use in this function)
     ret = iosf_mbi_write(QRK_MBI_UNIT_MM, QRK_MBI_MM_WRITE, reg++,
                                           ^
   arch/x86/platform/intel-quark/imr.c: In function 'imr_read':
>> arch/x86/platform/intel-quark/imr.c:131:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/QRK_MBI_MM_READ +114 arch/x86/platform/intel-quark/imr.c

28a375df Bryan O'Donoghue 2015-01-30  108   */
28a375df Bryan O'Donoghue 2015-01-30  109  static int imr_read(struct imr_device *idev, u32 imr_id, struct imr_regs *imr)
28a375df Bryan O'Donoghue 2015-01-30  110  {
28a375df Bryan O'Donoghue 2015-01-30  111  	u32 reg = imr_id * IMR_NUM_REGS + idev->reg_base;
28a375df Bryan O'Donoghue 2015-01-30  112  	int ret;
28a375df Bryan O'Donoghue 2015-01-30  113  
28a375df Bryan O'Donoghue 2015-01-30 @114  	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
28a375df Bryan O'Donoghue 2015-01-30  115  				reg++, &imr->addr_lo);
28a375df Bryan O'Donoghue 2015-01-30  116  	if (ret)
28a375df Bryan O'Donoghue 2015-01-30  117  		return ret;
28a375df Bryan O'Donoghue 2015-01-30  118  
28a375df Bryan O'Donoghue 2015-01-30  119  	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
28a375df Bryan O'Donoghue 2015-01-30  120  				reg++, &imr->addr_hi);
28a375df Bryan O'Donoghue 2015-01-30  121  	if (ret)
28a375df Bryan O'Donoghue 2015-01-30  122  		return ret;
28a375df Bryan O'Donoghue 2015-01-30  123  
28a375df Bryan O'Donoghue 2015-01-30  124  	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
28a375df Bryan O'Donoghue 2015-01-30  125  				reg++, &imr->rmask);
28a375df Bryan O'Donoghue 2015-01-30  126  	if (ret)
28a375df Bryan O'Donoghue 2015-01-30  127  		return ret;
28a375df Bryan O'Donoghue 2015-01-30  128  
c11a25f4 Fengguang Wu     2015-02-19  129  	return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
28a375df Bryan O'Donoghue 2015-01-30  130  				reg++, &imr->wmask);
28a375df Bryan O'Donoghue 2015-01-30 @131  }
28a375df Bryan O'Donoghue 2015-01-30  132  
28a375df Bryan O'Donoghue 2015-01-30  133  /**
28a375df Bryan O'Donoghue 2015-01-30  134   * imr_write - write an IMR at a given index.
28a375df Bryan O'Donoghue 2015-01-30  135   *
28a375df Bryan O'Donoghue 2015-01-30  136   * Requires caller to hold imr mutex.
28a375df Bryan O'Donoghue 2015-01-30  137   * Note lock bits need to be written independently of address bits.
28a375df Bryan O'Donoghue 2015-01-30  138   *
28a375df Bryan O'Donoghue 2015-01-30  139   * @idev:	pointer to imr_device structure.
28a375df Bryan O'Donoghue 2015-01-30  140   * @imr_id:	IMR entry to write.
28a375df Bryan O'Donoghue 2015-01-30  141   * @imr:	IMR structure representing address and access masks.
28a375df Bryan O'Donoghue 2015-01-30  142   * @lock:	indicates if the IMR lock bit should be applied.
28a375df Bryan O'Donoghue 2015-01-30  143   * @return:	0 on success or error code passed from mbi_iosf on failure.
28a375df Bryan O'Donoghue 2015-01-30  144   */
28a375df Bryan O'Donoghue 2015-01-30  145  static int imr_write(struct imr_device *idev, u32 imr_id,
28a375df Bryan O'Donoghue 2015-01-30  146  		     struct imr_regs *imr, bool lock)
28a375df Bryan O'Donoghue 2015-01-30  147  {
28a375df Bryan O'Donoghue 2015-01-30  148  	unsigned long flags;
28a375df Bryan O'Donoghue 2015-01-30  149  	u32 reg = imr_id * IMR_NUM_REGS + idev->reg_base;
28a375df Bryan O'Donoghue 2015-01-30  150  	int ret;
28a375df Bryan O'Donoghue 2015-01-30  151  
28a375df Bryan O'Donoghue 2015-01-30  152  	local_irq_save(flags);
28a375df Bryan O'Donoghue 2015-01-30  153  
28a375df Bryan O'Donoghue 2015-01-30 @154  	ret = iosf_mbi_write(QRK_MBI_UNIT_MM, QRK_MBI_MM_WRITE, reg++,
28a375df Bryan O'Donoghue 2015-01-30  155  				imr->addr_lo);
28a375df Bryan O'Donoghue 2015-01-30  156  	if (ret)
28a375df Bryan O'Donoghue 2015-01-30  157  		goto failed;

:::::: The code at line 114 was first introduced by commit
:::::: 28a375df16c2b6d01227541f3956568995aa5fda x86/intel/quark: Add Isolated Memory Regions for Quark X1000

:::::: TO: Bryan O'Donoghue <pure.logic@nexus-software.ie>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 51600 bytes --]