From: LABBE Corentin <montjoie.mailing@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
gnurou@gmail.com, ldewangan@nvidia.com, swarren@wwwdotorg.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra: fix a possible NULL dereference
Date: Thu, 12 Nov 2015 13:54:22 +0100 [thread overview]
Message-ID: <20151112125422.GA3758@Red> (raw)
In-Reply-To: <20151112122923.GA31671@ulmo>
On Thu, Nov 12, 2015 at 01:29:23PM +0100, Thierry Reding wrote:
> On Thu, Nov 12, 2015 at 08:26:03AM +0100, LABBE Corentin wrote:
> > of_match_device could return NULL, and so cause a NULL pointer
>
> No. There is no way that of_match_device() can ever fail. The driver
> core uses the same table to match the OF device to the driver, so the
> only case where of_match_device() would return NULL is if no match was
> found, in which case the tegra_i2c_probe() function would never have
> been called in the first place.
>
> Thierry
>
In a parallel thread for i2c-rcar, the conclusion was different.
https://lkml.org/lkml/2015/11/12/83
Regards
next prev parent reply other threads:[~2015-11-12 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 7:26 [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin
2015-11-12 12:29 ` Thierry Reding
2015-11-12 12:54 ` LABBE Corentin [this message]
2015-11-12 13:28 ` Thierry Reding
2015-11-12 13:45 ` Uwe Kleine-König
[not found] ` <20151112134519.GJ24008-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-12 13:55 ` Thierry Reding
2015-11-12 14:54 ` LABBE Corentin
2015-11-12 16:14 ` Thierry Reding
2016-01-23 11:07 ` Wolfram Sang
2016-01-23 10:56 ` Wolfram Sang
2015-11-12 13:40 ` Jon Hunter
2015-11-12 13:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112125422.GA3758@Red \
--to=montjoie.mailing@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).