From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH v2 04/10] i2c: rcar: remove spinlock
Date: Thu, 12 Nov 2015 16:52:36 +0100 [thread overview]
Message-ID: <20151112155235.GA11070@katana> (raw)
In-Reply-To: <5644AA7B.6090802@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Thu, Nov 12, 2015 at 06:04:27PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/12/2015 5:31 PM, Wolfram Sang wrote:
>
> >From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> >After making sure to reinit the HW and clear interrupts in the timeout
> >case, we know that interrupts are always disabled in the sections
> >protected by the spinlock.
>
> What about SMP? Spinlocks are mostly necessary for the SMP support, their
> tole isn't limited to disabling interrupts...
We have per-adapter locks in the core. Once a transfer is started, you
can't access the adapter unless the transfer is finished. But then, all
interrupts are off again.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-12 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 14:31 [PATCH v2 00/10] i2c: rcar: tackle race conditions in the driver Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 01/10] i2c: rcar: make sure clocks are on when doing clock calculation Wolfram Sang
2015-11-12 19:16 ` Sergei Shtylyov
2015-11-12 14:31 ` [PATCH v2 02/10] i2c: rcar: rework hw init Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 03/10] i2c: rcar: remove unused IOERROR state Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 04/10] i2c: rcar: remove spinlock Wolfram Sang
2015-11-12 15:04 ` Sergei Shtylyov
2015-11-12 15:52 ` Wolfram Sang [this message]
2015-11-12 14:31 ` [PATCH v2 05/10] i2c: rcar: refactor setup of a msg Wolfram Sang
2015-11-16 21:02 ` Laurent Pinchart
2015-11-17 7:00 ` Wolfram Sang
2015-11-17 7:38 ` Laurent Pinchart
2015-11-18 7:31 ` Wolfram Sang
2015-11-18 2:18 ` Magnus Damm
2015-11-18 6:45 ` Laurent Pinchart
2015-11-18 8:07 ` Wolfram Sang
2015-11-18 8:17 ` Magnus Damm
2015-11-12 14:31 ` [PATCH v2 06/10] i2c: rcar: init new messages in irq Wolfram Sang
2015-11-13 2:12 ` [PATCH v2 00/10] i2c: rcar: tackle race conditions in the driver Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112155235.GA11070@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).