From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christian Fetzer <fetzer.ch@gmail.com>
Cc: linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com, wsa@the-dreams.de,
galandilias@gmail.com, Thomas Brandon <tbrandonau@gmail.com>,
Eddi De Pieri <eddi@depieri.net>
Subject: Re: [PATCH v4 2/3] i2c-piix4: Add support for multiplexed main adapter in SB800
Date: Mon, 16 Nov 2015 14:31:54 +0200 [thread overview]
Message-ID: <20151116123154.GC1604@lahna.fi.intel.com> (raw)
In-Reply-To: <1447587184-21965-3-git-send-email-fetzer.ch@gmail.com>
On Sun, Nov 15, 2015 at 12:33:03PM +0100, Christian Fetzer wrote:
> The SB800 chipset supports a multiplexed main SMBus controller with
> four ports. The multiplexed ports share the same SMBus address and
> register set. The port is selected by bits 2:1 of the smb_en register
> (0x2C).
>
> Only one port can be active at any point in time therefore a mutex is
> needed in order to synchronize access.
>
> Additionally, the commit avoids requesting and releasing the SMBus base
> address index region on every multiplexed transfer by moving the
> request_region call into piix4_probe.
>
> Tested on HP ProLiant MicroServer G7 N54L (where this patch adds
> support to access sensor data from the w83795adg).
>
> Cc: Thomas Brandon <tbrandonau@gmail.com>
> Cc: Eddi De Pieri <eddi@depieri.net>
> Signed-off-by: Christian Fetzer <fetzer.ch@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2015-11-16 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 11:33 [PATCH v4 0/3] Support multiplexed main SMBus interface on SB800 Christian Fetzer
2015-11-15 11:33 ` [PATCH v4 1/3] i2c-piix4: Convert piix4_main_adapter to array Christian Fetzer
2015-11-15 11:33 ` [PATCH v4 2/3] i2c-piix4: Add support for multiplexed main adapter in SB800 Christian Fetzer
2015-11-16 9:29 ` Andy Shevchenko
2015-11-16 12:31 ` Mika Westerberg [this message]
2015-11-15 11:33 ` [PATCH v4 3/3] i2c-piix4: Add adapter port name support for SB800 chipset Christian Fetzer
2015-11-16 9:26 ` [PATCH v4 0/3] Support multiplexed main SMBus interface on SB800 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116123154.GC1604@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=eddi@depieri.net \
--cc=fetzer.ch@gmail.com \
--cc=galandilias@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=tbrandonau@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).