From: Wolfram Sang <wsa@the-dreams.de>
To: Christian Fetzer <fetzer.ch@gmail.com>
Cc: linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, galandilias@gmail.com
Subject: Re: [PATCH v5 0/3] Support multiplexed main SMBus interface on SB800
Date: Mon, 30 Nov 2015 14:37:29 +0100 [thread overview]
Message-ID: <20151130133728.GC1513@katana> (raw)
In-Reply-To: <1447960429-19256-1-git-send-email-fetzer.ch@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Thu, Nov 19, 2015 at 08:13:46PM +0100, Christian Fetzer wrote:
> This is an attempt to upstream the patches created by Thomas Brandon and
> Eddi De Pieri to support the multiplexed main SMBus interface on the SB800
> chipset. (https://www.mail-archive.com/linux-i2c@vger.kernel.org/msg06757.html)
>
> I have mainly rebased the latest patch version and tested the driver on a
> HP ProLiant MicroServer G7 N54L (where this patch allows to access sensor data
> from a w83795adg).
>
> The patched driver is running stable on the machine, given that ic2_piix4 is
> loaded before jc42 and w83795. If jc42 is loaded before i2c_piix4 calling
> sensors triggers some errors:
> ERROR: Can't get value of subfeature temp1_min_alarm: Can't read
>
> While the kernel log shows:
> i2c i2c-1: Transaction (pre): CNT=0c, CMD=05, ADD=31, DAT0=03, DAT1=c0
> i2c i2c-1: Error: no response!
> i2c i2c-1: Transaction (post): CNT=0c, CMD=05, ADD=31, DAT0=ff, DAT1=ff
> Unfortunately I don't know how to tackle this specific issue.
>
> Please review and let me know required changes in order to get this upstream
> finally.
Applied to for-next, thanks! And thanks to Mika and Andy for the review!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-30 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 19:13 [PATCH v5 0/3] Support multiplexed main SMBus interface on SB800 Christian Fetzer
2015-11-19 19:13 ` [PATCH v5 1/3] i2c-piix4: Convert piix4_main_adapter to array Christian Fetzer
2015-11-19 19:13 ` [PATCH v5 2/3] i2c-piix4: Add support for multiplexed main adapter in SB800 Christian Fetzer
2015-11-19 19:13 ` [PATCH v5 3/3] i2c-piix4: Add adapter port name support for SB800 chipset Christian Fetzer
2016-01-22 13:20 ` Jean Delvare
2015-11-30 13:37 ` Wolfram Sang [this message]
2016-01-22 12:50 ` [PATCH v5 0/3] Support multiplexed main SMBus interface on SB800 Jean Delvare
2016-01-23 13:47 ` fetzerch
2016-01-24 9:16 ` Jean Delvare
2016-01-24 12:07 ` Rudolf Marek
2016-01-25 11:13 ` Jean Delvare
2016-01-25 21:53 ` Christian Fetzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130133728.GC1513@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fetzer.ch@gmail.com \
--cc=galandilias@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).