From: Wolfram Sang <wsa@the-dreams.de>
To: "Yu, Xiangliang" <Xiangliang.Yu@amd.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xue, Ken" <Ken.Xue@amd.com>,
"Wan, Vincent" <Vincent.Wan@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"Wang, Annie" <Annie.Wang@amd.com>, "Li, Tony" <Tony.Li@amd.com>
Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller
Date: Tue, 1 Dec 2015 01:43:12 +0100 [thread overview]
Message-ID: <20151201004312.GA2064@katana> (raw)
In-Reply-To: <1C99EED8F51BBC41A8F1E645B51245F41AE8AAB0@scybexdag03.amd.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> >
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> >
>
> I see, how about change if statement to else if?
That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-01 0:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 12:34 [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller Xiangliang Yu
2015-11-05 13:52 ` Mika Westerberg
2015-11-06 4:34 ` Yu, Xiangliang
2015-11-06 7:46 ` Mika Westerberg
2015-11-06 8:33 ` Yu, Xiangliang
2015-12-01 0:43 ` Wolfram Sang [this message]
2015-11-06 8:59 ` Jarkko Nikula
2015-11-06 9:11 ` Yu, Xiangliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201004312.GA2064@katana \
--to=wsa@the-dreams.de \
--cc=Annie.Wang@amd.com \
--cc=Ken.Xue@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Tony.Li@amd.com \
--cc=Vincent.Wan@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).