From: Wolfram Sang <wsa@the-dreams.de>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: linux-i2c@vger.kernel.org, ian.molton@codethink.co.uk,
laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] i2c: emev2: add slave support
Date: Thu, 3 Dec 2015 22:03:39 +0100 [thread overview]
Message-ID: <20151203210339.GD8509@katana> (raw)
In-Reply-To: <1448842558-18654-2-git-send-email-niklas.soderlund@ragnatech.se>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Mon, Nov 30, 2015 at 01:15:58AM +0100, Niklas Söderlund wrote:
> Add I2C slave provider using the generic slave interface.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Looks mostly fine. Sparse says:
SPARSE
drivers/i2c/busses/i2c-emev2.c:267:25: warning: mixing declarations and code
drivers/i2c/busses/i2c-emev2.c:289:25: warning: mixing declarations and code
Please fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-03 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 0:15 [PATCH] i2c: emev2: add slave support Niklas Söderlund
2015-11-30 0:15 ` Niklas Söderlund
2015-12-03 21:03 ` Wolfram Sang [this message]
2015-12-02 10:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203210339.GD8509@katana \
--to=wsa@the-dreams.de \
--cc=ian.molton@codethink.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).