From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Gao Pan <b54642@freescale.com>
Cc: wsa@the-dreams.de, B20596@freescale.com, b38611@freescale.com,
r49496@freescale.com, linux-i2c@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [Patch V2] i2c: imx: init bus recovery info before adding i2c adapter
Date: Wed, 9 Dec 2015 08:00:37 +0100 [thread overview]
Message-ID: <20151209070037.GV5072@pengutronix.de> (raw)
In-Reply-To: <1449630502-14835-1-git-send-email-b54642@freescale.com>
Hello,
On Wed, Dec 09, 2015 at 11:08:22AM +0800, Gao Pan wrote:
> During driver probe, i2c_imx_init_recovery_info() must come before
> i2c_add_numbered_adapter(), because the get/set_scl() functions
> are assigned in i2c_register_adapter() under the conditon that bus
> recover_info are initialized. Otherwise, get/set_scl() function
> pointers never get assigned.
>
> In such case, when i2c_generic_gpio_recovery() is used for bus recovery,
> there will be kernel crash because bri->set_scl is NULL.
>
> The solution to this bug is moving i2c_imx_init_recovery_info() before
> i2c_register_adapter().
>
> Signed-off-by: Gao Pan <b54642@freescale.com>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
I wonder why your S-o-b line isn't below Fugang Duan's. These lines are
supposed to show the order of people that touched the patch. So usually
the Author is the first person to sign off and the person who sends the
patch is the last.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-12-09 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 3:08 [Patch V2] i2c: imx: init bus recovery info before adding i2c adapter Gao Pan
2015-12-09 7:00 ` Uwe Kleine-König [this message]
2015-12-09 10:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209070037.GV5072@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=B20596@freescale.com \
--cc=b38611@freescale.com \
--cc=b54642@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=r49496@freescale.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).