From: Wolfram Sang <wsa@the-dreams.de>
To: Xiangliang Yu <Xiangliang.Yu@amd.com>
Cc: andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, SPG_Linux_Kernel@amd.com
Subject: Re: [PATCH v2] I2C: designware: fix IO timeout issue for AMD controller
Date: Sat, 12 Dec 2015 18:03:22 +0100 [thread overview]
Message-ID: <20151212170322.GB1530@katana> (raw)
In-Reply-To: <1449835373-4669-1-git-send-email-Xiangliang.Yu@amd.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Fri, Dec 11, 2015 at 08:02:53PM +0800, Xiangliang Yu wrote:
> Because of some hardware limitation, AMD I2C controller can't
> trigger pending interrupt if interrupt status has been changed
> after clearing interrupt status bits. Then, I2C will lost
> interrupt and IO timeout.
>
> According to hardware design, this patch implements a workaround
> to disable i2c controller interrupt and re-enable i2c interrupt
> before exiting ISR.
>
> To reduce the performance impacts on other vendors, use unlikely
> function to check flag in ISR.
> ---
Don't manually add "---". This breaks a lot of workflow scripts.
"Patchwork" missed your Signed-off, for example!
> Changes in v2:
> - pass flags with ->driver_data
> - unmask interrupt right after masking
This paragraph...
>
> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
> ---
... needs to go here.
However, I fixed it this time and applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-12 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 12:02 [PATCH v2] I2C: designware: fix IO timeout issue for AMD controller Xiangliang Yu
2015-12-11 8:42 ` Jarkko Nikula
2015-12-12 17:03 ` Wolfram Sang [this message]
2015-12-13 12:01 ` Yu, Xiangliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151212170322.GB1530@katana \
--to=wsa@the-dreams.de \
--cc=SPG_Linux_Kernel@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox