From: Wolfram Sang <wsa@the-dreams.de>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-i2c@vger.kernel.org, linux-pm@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls
Date: Sat, 19 Dec 2015 11:52:13 +0100 [thread overview]
Message-ID: <20151219105213.GB2571@katana> (raw)
In-Reply-To: <20151217094655.GV6058@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Thu, Dec 17, 2015 at 09:46:55AM +0000, Charles Keepax wrote:
> On Wed, Dec 16, 2015 at 02:53:07PM +0100, Sylwester Nawrocki wrote:
> > On 15/12/15 19:14, Wolfram Sang wrote:
> > > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with
> > > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op.
> > > So, we can remove these calls.
> >
> > Won't this break i2c client devices that use runtime PM? Not sure
> > if any cases of such client exist now, I'll try to find some time
> > to test this change.
> >
>
> Our CODECs can be controlled over I2C and use runtime PM.
> However, this change doesn't seem to have any adverse effect on
> them that I can find.
>
> Tested-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks for testing!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-19 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 18:14 [PATCH] i2c: s3c2410: remove superfluous runtime PM calls Wolfram Sang
2015-12-16 13:53 ` Sylwester Nawrocki
2015-12-17 9:46 ` Charles Keepax
2015-12-19 10:52 ` Wolfram Sang [this message]
2015-12-19 10:50 ` Wolfram Sang
2015-12-19 17:05 ` Alan Stern
2015-12-19 21:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219105213.GB2571@katana \
--to=wsa@the-dreams.de \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox