From: Baruch Siach <baruch@tkos.co.il>
To: Rolland Chau <zourongrong@gmail.com>
Cc: linux-i2c@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: designware i2c bus driver
Date: Wed, 23 Dec 2015 12:29:33 +0200 [thread overview]
Message-ID: <20151223102933.GL1548@tarshish> (raw)
In-Reply-To: <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com>
Hi Rolland,
On Wed, Dec 23, 2015 at 05:12:47PM +0800, Rolland Chau wrote:
> 2015-12-23 15:45 GMT+08:00 Baruch Siach <baruch@tkos.co.il>:
> > On Wed, Dec 23, 2015 at 02:56:20PM +0800, Rolland Chau wrote:
> > > I found in i2c-designware-platdrv.c , the i2c retry time is not set,
> > > and the default value is 0, so if I use in kernel mode, I can't set
> > > the retry time. I want to konw why you don't initialize the value in
> > > probe()?
> >
> > I don't see any retry handling in current driver code. What kernel version
> > are
> > you using? What retry value do you refer to?
>
> I2c_adapter.retries. It means retry times when i2c transfer failed.
Right. Makes sense. As far as I can see current code retries the transfer only
on Tx arbitration loss. I'll send a patch later if you don't beat me to it.
> > Adding linux-i2c mailing list to Cc.
>
> I subscribe to linux-i2c, but there is no response.
Adding i2c-designware-* maintainers to Cc as well.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-12-23 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABTftiTOHfs_h9Kkb4=aA-bDKhWPxCaCZ2fRxAjHeitmz9pvsA@mail.gmail.com>
2015-12-23 7:45 ` designware i2c bus driver Baruch Siach
[not found] ` <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com>
2015-12-23 10:29 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223102933.GL1548@tarshish \
--to=baruch@tkos.co.il \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).