Re: designware i2c bus driver

Re: designware i2c bus driver

[Baruch Siach]

Hi Rolland,

On Wed, Dec 23, 2015 at 02:56:20PM +0800, Rolland Chau wrote:
> I found in i2c-designware-platdrv.c , the i2c retry time is not set,
> and the default value is 0, so if I use in kernel mode, I can't set
> the retry time. I want to konw why you don't initialize the value in
> probe()?

I don't see any retry handling in current driver code. What kernel version are 
you using? What retry value do you refer to?

Adding linux-i2c mailing list to Cc.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Re: designware i2c bus driver

[Baruch Siach]

Hi Rolland,

On Wed, Dec 23, 2015 at 05:12:47PM +0800, Rolland Chau wrote:
> 2015-12-23 15:45 GMT+08:00 Baruch Siach <baruch@tkos.co.il>:
> > On Wed, Dec 23, 2015 at 02:56:20PM +0800, Rolland Chau wrote:
> > > I found in i2c-designware-platdrv.c , the i2c retry time is not set,
> > > and the default value is 0, so if I use in kernel mode, I can't set
> > > the retry time. I want to konw why you don't initialize the value in
> > > probe()?
> >
> > I don't see any retry handling in current driver code. What kernel version
> > are
> > you using? What retry value do you refer to?
>
> I2c_adapter.retries. It means retry times when i2c transfer failed.

Right. Makes sense. As far as I can see current code retries the transfer only 
on Tx arbitration loss. I'll send a patch later if you don't beat me to it.

> > Adding linux-i2c mailing list to Cc.
>
> I subscribe to linux-i2c, but there is no response.

Adding i2c-designware-* maintainers to Cc as well.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -