From: Wolfram Sang <wsa@the-dreams.de>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com, lho@apm.com, Ken.Xue@amd.com,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided
Date: Mon, 4 Jan 2016 17:15:25 +0100 [thread overview]
Message-ID: <20160104161525.GC1599@katana> (raw)
In-Reply-To: <1451920655-10798-1-git-send-email-Suravee.Suthikulpanit@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
On Mon, Jan 04, 2016 at 09:17:35AM -0600, Suravee Suthikulpanit wrote:
> The current driver uses input clock source frequency to calculate
> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not
> currently have a good way to provide the frequency information.
> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used
> to directly provide these values. So, the clock information should
> no longer be required during probing.
>
> However, since clk can be invalid, additional checks must be done where
> we are making use of it.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> Tested-by: Loc Ho <lho@apm.com>
> ---
>
> Note: This has been tested on AMD Seattle RevB for both DT and ACPI.
>
> Changes from V3 (https://lkml.org/lkml/2015/12/22/596):
> * Add i2c_dw_plat_prepare_clk() per Andy's suggestion
> * Add tested-by Loc Ho.
The changes from V3 are big enough that I'd appreciate a new Tested-by
tag.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-04 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 15:17 [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided Suravee Suthikulpanit
2016-01-04 16:15 ` Wolfram Sang [this message]
2016-01-05 19:58 ` Loc Ho
2016-01-07 0:31 ` Loc Ho
2016-01-07 5:05 ` Suravee Suthikulpanit
2016-01-10 8:38 ` Wolfram Sang
2016-01-13 22:46 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104161525.GC1599@katana \
--to=wsa@the-dreams.de \
--cc=Ken.Xue@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).