From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jianqun Xu" <jay.xu@rock-chips.com>,
"David Wu" <wdc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
dianders@chromium.org, huangtao@rock-chips.com,
zyw@rock-chips.com, hl@rock-chips.com, xjq@rock-chips.com,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David Wu" <david.wu@rock-chips.com>
Subject: Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version
Date: Mon, 4 Jan 2016 20:40:42 +0100 [thread overview]
Message-ID: <20160104194042.GD1522@katana> (raw)
In-Reply-To: <CAHp75VfkteDvC0KUXOXDik9rQeanTXLn9Qq3wux-0rxk5ZotNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
> >> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
> >> scl_rate,
> >> + unsigned long scl_rise_ns,
> >> + unsigned long scl_fall_ns,
> >> + unsigned long sda_fall_ns,
>
> Wolfram did some sturct to assign the parameters from device properties.
> It might be re-used here.
Yes, I think it makes sense to convert the driver first to use
the new i2c_parse_fw_timings() function and see if it fits (or if we need
to extend it perhaps).
David, does this make sense to you?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-04 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 14:33 [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version David Wu
2015-12-11 14:33 ` [PATCH v1 2/3] i2c: rk3x: new way to calc_divs " David Wu
[not found] ` <1449844384-6236-1-git-send-email-wdc-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-12-11 14:33 ` [PATCH v1 3/3] i2c: rk3x: support I2C Hs-mode for rk3399 David Wu
2015-12-15 0:32 ` [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version Jianqun Xu
2015-12-20 15:43 ` Andy Shevchenko
2016-01-04 19:40 ` Wolfram Sang [this message]
2016-01-08 13:12 ` David.Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104194042.GD1522@katana \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wdc@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).