From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Christian Fetzer <fetzer.ch@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c-piix4: Fix SB800 locking
Date: Mon, 25 Jan 2016 11:29:13 +0200 [thread overview]
Message-ID: <20160125092913.GP2410@lahna.fi.intel.com> (raw)
In-Reply-To: <20160122141202.09c94802@endymion.delvare>
On Fri, Jan 22, 2016 at 02:12:02PM +0100, Jean Delvare wrote:
> We need a single mutex for all 4 shared SMBus ports on the SB800. A
> per-port mutex doesn't protect us from concurrent access.
>
> In theory the mutex should be per PCI device, however in practice we
> know that there's only ever a single instance of the device in a given
> system so we can use a global.
>
> Also take the mutex during initialization, as first port may be already
> in use when second port is initialized.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Christian Fetzer <fetzer.ch@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
The patch looks correct to me,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks Jean for looking into this.
next prev parent reply other threads:[~2016-01-25 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:12 [PATCH] i2c-piix4: Fix SB800 locking Jean Delvare
2016-01-23 13:26 ` fetzerch
2016-01-25 9:29 ` Mika Westerberg [this message]
2016-01-26 5:42 ` Wolfram Sang
2016-01-26 7:04 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125092913.GP2410@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fetzer.ch@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).