From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 3/4] mfd: menf21bmc: Add additional sysfs entries for BMC status information Date: Mon, 25 Jan 2016 16:07:30 +0000 Message-ID: <20160125160730.GV3368@x1> References: <278283b66344e1ca556761abbcb87a20ecb21436.1452514293.git.andreas.werner@men.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <278283b66344e1ca556761abbcb87a20ecb21436.1452514293.git.andreas.werner@men.de> Sender: linux-kernel-owner@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Mon, 11 Jan 2016, Andreas Werner wrote: > This patch adds additional sysfs entries to provide status > information to the userland. >=20 > The following informations are now provided: > - Get operation hours counter > - Get board slot address > - Get powercycle counter > - Set/get Hw Variant >=20 > Signed-off-by: Andreas Werner > --- > drivers/mfd/menf21bmc.c | 93 +++++++++++++++++++++++++++++++++++++++= ++++++++++ > 1 file changed, 93 insertions(+) Acked-by: Lee Jones > diff --git a/drivers/mfd/menf21bmc.c b/drivers/mfd/menf21bmc.c > index b11bd6b..dd068c0 100644 > --- a/drivers/mfd/menf21bmc.c > +++ b/drivers/mfd/menf21bmc.c > @@ -20,6 +20,10 @@ > #define BMC_CMD_REV_MAJOR 0x80 > #define BMC_CMD_REV_MINOR 0x81 > #define BMC_CMD_REV_MAIN 0x82 > +#define BMC_CMD_SLOT_ADDRESS 0x8c > +#define BMC_CMD_HW_VARIANT 0x8f > +#define BMC_CMD_PWRCYCL_CNT 0x93 > +#define BMC_CMD_OP_HRS_CNT 0x94 > =20 > static struct mfd_cell menf21bmc_cell[] =3D { > { .name =3D "menf21bmc_wdt", }, > @@ -66,11 +70,100 @@ static ssize_t menf21bmc_mode_store(struct devic= e *dev, > return size; > } > =20 > +static ssize_t menf21bmc_hw_variant_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct i2c_client *client =3D to_i2c_client(dev); > + int val; > + > + val =3D i2c_smbus_read_word_data(client, BMC_CMD_HW_VARIANT); > + if (val < 0) > + return val; > + > + return sprintf(buf, "0x%04x\n", val); > + > +} > + > +static ssize_t menf21bmc_hw_variant_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t size) > +{ > + struct i2c_client *client =3D to_i2c_client(dev); > + unsigned long hw_variant; > + int ret; > + > + if (kstrtoul(buf, 0, &hw_variant)) > + return -EINVAL; > + > + if (hw_variant < 0 || hw_variant > 0xffff) > + return -EINVAL; > + > + ret =3D i2c_smbus_write_word_data(client, BMC_CMD_HW_VARIANT, > + hw_variant); > + if (ret < 0) > + return ret; > + > + return size; > + > +} > + > +static ssize_t menf21bmc_pwrcycl_cnt_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct i2c_client *client =3D to_i2c_client(dev); > + int val; > + > + val =3D i2c_smbus_read_word_data(client, BMC_CMD_PWRCYCL_CNT); > + if (val < 0) > + return val; > + > + return sprintf(buf, "%d\n", val); > +} > + > +static ssize_t menf21bmc_op_hrs_cnt_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct i2c_client *client =3D to_i2c_client(dev); > + int val; > + > + val =3D i2c_smbus_read_word_data(client, BMC_CMD_OP_HRS_CNT); > + if (val < 0) > + return val; > + > + return sprintf(buf, "%d\n", val); > +} > + > +static ssize_t menf21bmc_slot_address_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct i2c_client *client =3D to_i2c_client(dev); > + int val; > + > + val =3D i2c_smbus_read_byte_data(client, BMC_CMD_SLOT_ADDRESS); > + if (val < 0) > + return val; > + > + return sprintf(buf, "%d\n", val); > +} > + > static DEVICE_ATTR(mode, S_IRUGO | S_IWUSR, menf21bmc_mode_show, > menf21bmc_mode_store); > +static DEVICE_ATTR(hw_variant, S_IRUGO | S_IWUSR, menf21bmc_hw_varia= nt_show, > + menf21bmc_hw_variant_store); > +static DEVICE_ATTR(pwrcycl_cnt, S_IRUGO, menf21bmc_pwrcycl_cnt_show,= NULL); > +static DEVICE_ATTR(op_hrs_cnt, S_IRUGO, menf21bmc_op_hrs_cnt_show, N= ULL); > +static DEVICE_ATTR(slot_address, S_IRUGO, menf21bmc_slot_address_sho= w, NULL); > =20 > static struct attribute *menf21bmc_attributes[] =3D { > &dev_attr_mode.attr, > + &dev_attr_hw_variant.attr, > + &dev_attr_pwrcycl_cnt.attr, > + &dev_attr_op_hrs_cnt.attr, > + &dev_attr_slot_address.attr, > NULL > }; > =20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog