* [PATCH] drivers : i2c: Allow i2c devices share an interrupt
@ 2016-01-12 8:01 ying.zhang22455
2016-01-26 6:08 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: ying.zhang22455 @ 2016-01-12 8:01 UTC (permalink / raw)
To: linux-i2c; +Cc: X.Xie, Ying Zhang, Ying Zhang
From: Ying Zhang <b40530@freescale.com>
The I2C devices on I2C1, I2C2, I2C3, I2C4 share interrupts,
but the flag is not set when requesting IRQ.
This patch set the flag to IRQF_SHARED.
Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
---
drivers/i2c/busses/i2c-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index d4d8536..611b269 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1094,7 +1094,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
}
/* Request IRQ */
- ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, 0,
+ ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED,
pdev->name, i2c_imx);
if (ret) {
dev_err(&pdev->dev, "can't claim irq %d\n", irq);
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: drivers : i2c: Allow i2c devices share an interrupt
2016-01-12 8:01 [PATCH] drivers : i2c: Allow i2c devices share an interrupt ying.zhang22455
@ 2016-01-26 6:08 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2016-01-26 6:08 UTC (permalink / raw)
To: ying.zhang22455; +Cc: linux-i2c, X.Xie, Ying Zhang
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Tue, Jan 12, 2016 at 04:01:47PM +0800, ying.zhang22455@nxp.com wrote:
> From: Ying Zhang <b40530@freescale.com>
>
> The I2C devices on I2C1, I2C2, I2C3, I2C4 share interrupts,
> but the flag is not set when requesting IRQ.
For which SoC is that information? And with which devices is it shared?
Please update the commit message.
>
> This patch set the flag to IRQF_SHARED.
>
> Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index d4d8536..611b269 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1094,7 +1094,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> }
>
> /* Request IRQ */
> - ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, 0,
> + ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED,
> pdev->name, i2c_imx);
> if (ret) {
> dev_err(&pdev->dev, "can't claim irq %d\n", irq);
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-26 6:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-12 8:01 [PATCH] drivers : i2c: Allow i2c devices share an interrupt ying.zhang22455
2016-01-26 6:08 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).