From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
"David E. Box" <david.e.box@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: designware-baytrail: Fix the Kconfig dependency fix
Date: Thu, 4 Feb 2016 20:51:16 +0100 [thread overview]
Message-ID: <20160204205116.1cc08fb8@endymion> (raw)
In-Reply-To: <56B33A34.7000400@linux.intel.com>
On Thu, 4 Feb 2016 13:47:00 +0200, Jarkko Nikula wrote:
> On 02/02/2016 03:33 PM, Jean Delvare wrote:
> > Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for
> > proper Kconfig dependencies") claims that the "Baytrail driver" isn't
> > tristate. But in fact there is no such thing as a "Baytrail driver",
> > i2c-designware-baytrail is not a stand-alone driver but an optional
> > addition to the i2c-designware-platform driver, and that driver *is*
> > tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't
> > be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
> >
> I had a similar patch waiting for David's ack because I didn't know are
> there any problems when IOSF_MBI is module but I forgot to ping again.
>
> David: can you ack this in case IOSF_MBI=m is ok.
>
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: David E. Box <david.e.box@linux.intel.com>
> > Cc: Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Wow, I messed up big time :( For clarity, this patch is not (yet)
signed-off by Wolfram, it's a copy-and-paste mistake on my side.
> > ---
> > drivers/i2c/busses/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-4.5-rc2.orig/drivers/i2c/busses/Kconfig 2016-02-02 13:36:02.621152859 +0100
> > +++ linux-4.5-rc2/drivers/i2c/busses/Kconfig 2016-02-02 14:06:07.185912775 +0100
> > @@ -490,7 +490,7 @@ config I2C_DESIGNWARE_PCI
> >
> > config I2C_DESIGNWARE_BAYTRAIL
> > bool "Intel Baytrail I2C semaphore support"
> > - depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI
> > + depends on I2C_DESIGNWARE_PLATFORM && (IOSF_MBI=y || IOSF_MBI=I2C_DESIGNWARE_PLATFORM) && ACPI
>
> One minor comment: could you split this into two depends on lines in
> order to avoid long lines?
Certainly. I'll resend the patch with this change after David approves
it.
> Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Thanks for the reviews!
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-02-04 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 13:33 [PATCH] i2c: designware-baytrail: Fix the Kconfig dependency fix Jean Delvare
2016-02-04 11:47 ` Jarkko Nikula
2016-02-04 19:51 ` Jean Delvare [this message]
2016-02-12 19:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204205116.1cc08fb8@endymion \
--to=jdelvare@suse.de \
--cc=david.e.box@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).