From: Jean Delvare <jdelvare@suse.de>
To: Alexandra Yates <alexandra.yates@linux.intel.com>
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
Date: Wed, 10 Feb 2016 10:42:31 +0100 [thread overview]
Message-ID: <20160210104231.3fa07523@endymion> (raw)
In-Reply-To: <1454714564-8632-1-git-send-email-alexandra.yates@linux.intel.com>
Hi Alexandra,
On Fri, 5 Feb 2016 15:22:44 -0800, Alexandra Yates wrote:
> Changes log v2 to v3: Clarified commit message. No changes in code.
>
> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> resources have been moved to reside under the i801 SMBus host
> controller whereas previously they were under the LPC device.
>
> This patch adds Intel lewisburg SMBus support for iTCO device.
> It allows to load watchdog dynamically when the hardware is
> present. This patch is an addition
> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
> Intel Lewisburg device IDs".
>
> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f62d697..27fa0cb 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> switch (dev->device) {
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
> case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Note this checkpatch warning though:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#40:
to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
It is also common to add a "Fixes:" line with that information so that
patch backporting can be automated. And as I said before I would tag
the patch for stable as well.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-02-10 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO>
2016-02-05 23:22 ` [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates
2016-02-10 9:42 ` Jean Delvare [this message]
2016-02-12 19:09 ` Wolfram Sang
2016-02-17 19:10 ` Alexandra Yates
2016-02-18 1:21 ` Alexandra Yates
2016-02-18 1:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210104231.3fa07523@endymion \
--to=jdelvare@suse.de \
--cc=alexandra.yates@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).