linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Ray Jui <rjui@broadcom.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	Icarus Chau <ichau@broadcom.com>
Subject: Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case
Date: Fri, 12 Feb 2016 20:31:19 +0100	[thread overview]
Message-ID: <20160212193119.GR1520@katana> (raw)
In-Reply-To: <1453940842-9658-2-git-send-email-rjui@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

> +static int bcm_iproc_i2c_init(struct bcm_iproc_i2c_dev *iproc_i2c);
> +static void bcm_iproc_i2c_enable_disable(struct bcm_iproc_i2c_dev *iproc_i2c,
> +					 bool enable);

Can't we move these functions instead of having the extra declarations?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-02-12 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  0:27 [PATCH 0/3] iProc I2C driver enhancement Ray Jui
2016-01-28  0:27 ` [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case Ray Jui
2016-02-12 19:31   ` Wolfram Sang [this message]
2016-02-12 19:32     ` Ray Jui
2016-01-28  0:27 ` [PATCH 2/3] i2c: iproc: Fix typo in the driver Ray Jui
2016-01-28  0:27 ` [PATCH 3/3] i2c: iproc: Support larger TX transfer Ray Jui
2016-02-12 19:33   ` Wolfram Sang
2016-02-12 19:33     ` Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212193119.GR1520@katana \
    --to=wsa@the-dreams.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=ichau@broadcom.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).