From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Christian Fetzer <fetzer.ch@gmail.com>
Subject: Re: [PATCH 1/3] i2c-piix4: Support alternative port selection register
Date: Sat, 13 Feb 2016 22:51:47 +0100 [thread overview]
Message-ID: <20160213225147.26c64bbf@endymion> (raw)
In-Reply-To: <20160212192720.GQ1520@katana>
Hi Wolfram,
On Fri, 12 Feb 2016 20:27:20 +0100, Wolfram Sang wrote:
> On Fri, Jan 29, 2016 at 10:44:52AM +0100, Jean Delvare wrote:
> > The SB800 register reference guide says that the SMBus port selection
> > bits may not always be in register Smbus0En (0x2c) but could
> > alternatively be found in register Smbus0Sel (0x2e) depending on the
> > settings in register Smbus0SelEn (0x2f.) Add support for this
> > configuration.
>
> Were you able to test both cases?
I don't have the hardware myself so I was not able to test any case.
I was hoping Christian would test. This is the reason why I am logging
which register is used, so that we know if the alternative setting is
ever used. I found the potential problem by looking at the datasheet,
it's not something that has been reported (yet.)
Meanwhile I have found a datasheet for device 780Bh (named Bolton FCH
on AMD's web site, but Hudson2 in our driver) which suggest that the
"alternative" setting is the only possible one on this chipset. The
register used to figure out the setting is marked as reserved. If the
register exists still and the relevant bit is set, then my patch should
work. If not then a better patch will be needed.
I'll try to gain access to a system with a Bolton FCH and experiment
with it.
Then there's the most recent device, codenamed "CZ", for which I have
no information at all.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-02-13 21:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 9:41 [PATCH 0/3] Improvements to the i2c-piix4 driver Jean Delvare
2016-01-29 9:44 ` [PATCH 1/3] i2c-piix4: Support alternative port selection register Jean Delvare
2016-01-29 10:59 ` Mika Westerberg
2016-01-29 12:04 ` Jean Delvare
2016-02-12 19:27 ` Wolfram Sang
2016-02-13 21:51 ` Jean Delvare [this message]
2016-02-14 8:39 ` fetzerch
2016-02-14 9:55 ` Jean Delvare
2016-02-15 17:30 ` Jean Delvare
2016-02-15 17:37 ` Wolfram Sang
2016-02-15 20:52 ` Jean Delvare
2016-01-29 9:45 ` [PATCH 2/3] i2c-piix4: Always use the same type for port Jean Delvare
2016-01-29 10:59 ` Mika Westerberg
2016-02-24 10:40 ` Wolfram Sang
2016-01-29 9:46 ` [PATCH 3/3] i2c-piix4: Pre-shift the port number Jean Delvare
2016-01-29 11:02 ` Mika Westerberg
2016-01-29 11:09 ` Jean Delvare
2016-02-24 10:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213225147.26c64bbf@endymion \
--to=jdelvare@suse.de \
--cc=fetzer.ch@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).