From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID Date: Fri, 19 Feb 2016 10:39:17 +0200 Message-ID: <20160219083917.GE1491@lahna.fi.intel.com> References: <1455807273-133516-1-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:43595 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946272AbcBSIj2 (ORCPT ); Fri, 19 Feb 2016 03:39:28 -0500 Content-Disposition: inline In-Reply-To: <1455807273-133516-1-git-send-email-mika.westerberg@linux.intel.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Seth Heasley , Neil Horman , linux-i2c@vger.kernel.org, alexandra.yates@intel.com On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote: > Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add > DNV PCI ID to the list of supported devices. > > Signed-off-by: Mika Westerberg Wolfram, Please do not yet apply this patch. It seems to have same PCI ID that Alexandra (Cc'd) added to i2c-i801.c. Alexandra, are you sure that the PCI ID you added for DNV is actually compatible with i2c-i801.c? > --- > drivers/i2c/busses/i2c-ismt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c > index 7ba795b24e75..24c48e899a22 100644 > --- a/drivers/i2c/busses/i2c-ismt.c > +++ b/drivers/i2c/busses/i2c-ismt.c > @@ -76,6 +76,7 @@ > #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59 > #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a > #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15 > +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac > > #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */ > #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */ > @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) }, > { 0, } > }; > > -- > 2.7.0