* [PATCH] i2c: ismt: Add Intel DNV PCI ID
@ 2016-02-18 14:54 Mika Westerberg
2016-02-19 8:39 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2016-02-18 14:54 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Seth Heasley, Neil Horman, Mika Westerberg, linux-i2c
Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add
DNV PCI ID to the list of supported devices.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/i2c/busses/i2c-ismt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 7ba795b24e75..24c48e899a22 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -76,6 +76,7 @@
#define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59
#define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
#define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
+#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
#define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
#define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */
@@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
{ 0, }
};
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
2016-02-18 14:54 [PATCH] i2c: ismt: Add Intel DNV PCI ID Mika Westerberg
@ 2016-02-19 8:39 ` Mika Westerberg
2016-02-19 17:24 ` Yates, Alexandra
2016-02-19 20:45 ` Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Mika Westerberg @ 2016-02-19 8:39 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Seth Heasley, Neil Horman, linux-i2c, alexandra.yates
On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote:
> Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add
> DNV PCI ID to the list of supported devices.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Wolfram,
Please do not yet apply this patch. It seems to have same PCI ID that
Alexandra (Cc'd) added to i2c-i801.c.
Alexandra, are you sure that the PCI ID you added for DNV is actually
compatible with i2c-i801.c?
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 7ba795b24e75..24c48e899a22 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -76,6 +76,7 @@
> #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59
> #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
> +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
>
> #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
> #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */
> @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
> { 0, }
> };
>
> --
> 2.7.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] i2c: ismt: Add Intel DNV PCI ID
2016-02-19 8:39 ` Mika Westerberg
@ 2016-02-19 17:24 ` Yates, Alexandra
2016-03-03 21:15 ` Wolfram Sang
2016-02-19 20:45 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Yates, Alexandra @ 2016-02-19 17:24 UTC (permalink / raw)
To: Mika Westerberg, Wolfram Sang
Cc: Heasley, Seth, Neil Horman, linux-i2c@vger.kernel.org
Hi Mika,
> -----Original Message-----
> From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
> Sent: Friday, February 19, 2016 12:39 AM
> To: Wolfram Sang <wsa@the-dreams.de>
> Cc: Heasley, Seth <seth.heasley@intel.com>; Neil Horman
> <nhorman@tuxdriver.com>; linux-i2c@vger.kernel.org; Yates, Alexandra
> <alexandra.yates@intel.com>
> Subject: Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
>
> On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote:
> > Intel DNV has the same iSMT SMBus host controller than Intel Avoton.
> > Add DNV PCI ID to the list of supported devices.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Wolfram,
>
> Please do not yet apply this patch. It seems to have same PCI ID that
> Alexandra (Cc'd) added to i2c-i801.c.
>
> Alexandra, are you sure that the PCI ID you added for DNV is actually
> compatible with i2c-i801.c?
>
I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows:
Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host
In the same document there is a list of PCI IDs.
> > ---
> > drivers/i2c/busses/i2c-ismt.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-ismt.c
> > b/drivers/i2c/busses/i2c-ismt.c index 7ba795b24e75..24c48e899a22
> > 100644
> > --- a/drivers/i2c/busses/i2c-ismt.c
> > +++ b/drivers/i2c/busses/i2c-ismt.c
> > @@ -76,6 +76,7 @@
> > #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59
> > #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> > #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
> > +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
> >
> > #define ISMT_DESC_ENTRIES 2 /* number of descriptor
> entries */
> > #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to
> attempt */
> > @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = {
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_S1200_SMT0) },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_DNV_SMT) },
> > { 0, }
> > };
> >
> > --
> > 2.7.0
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
2016-02-19 8:39 ` Mika Westerberg
2016-02-19 17:24 ` Yates, Alexandra
@ 2016-02-19 20:45 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-02-19 20:45 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Seth Heasley, Neil Horman, linux-i2c, alexandra.yates
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Fri, Feb 19, 2016 at 10:39:17AM +0200, Mika Westerberg wrote:
> On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote:
> > Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add
> > DNV PCI ID to the list of supported devices.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Wolfram,
>
> Please do not yet apply this patch. It seems to have same PCI ID that
> Alexandra (Cc'd) added to i2c-i801.c.
>
> Alexandra, are you sure that the PCI ID you added for DNV is actually
> compatible with i2c-i801.c?
OK, I also dropped Alexandra's patch until this is cleared.
Thanks for the heads up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
2016-02-19 17:24 ` Yates, Alexandra
@ 2016-03-03 21:15 ` Wolfram Sang
2016-03-04 8:38 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2016-03-03 21:15 UTC (permalink / raw)
To: Yates, Alexandra
Cc: Mika Westerberg, Heasley, Seth, Neil Horman,
linux-i2c@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Mika,
> I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows:
> Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host
>
> In the same document there is a list of PCI IDs.
Did this comment help?
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID
2016-03-03 21:15 ` Wolfram Sang
@ 2016-03-04 8:38 ` Mika Westerberg
0 siblings, 0 replies; 6+ messages in thread
From: Mika Westerberg @ 2016-03-04 8:38 UTC (permalink / raw)
To: Wolfram Sang
Cc: Yates, Alexandra, Heasley, Seth, Neil Horman,
linux-i2c@vger.kernel.org
On Thu, Mar 03, 2016 at 10:15:38PM +0100, Wolfram Sang wrote:
> Mika,
>
> > I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows:
> > Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host
> >
> > In the same document there is a list of PCI IDs.
>
> Did this comment help?
Not really.
We are figuring out which one it is and will send a new patch as soon as
we know better :)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-04 8:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-18 14:54 [PATCH] i2c: ismt: Add Intel DNV PCI ID Mika Westerberg
2016-02-19 8:39 ` Mika Westerberg
2016-02-19 17:24 ` Yates, Alexandra
2016-03-03 21:15 ` Wolfram Sang
2016-03-04 8:38 ` Mika Westerberg
2016-02-19 20:45 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).