From: Wolfram Sang <wsa@the-dreams.de>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: linux-i2c@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] i2c: brcmstb: allocate correct amount of memory for regmap
Date: Mon, 22 Feb 2016 09:05:22 +0100 [thread overview]
Message-ID: <20160222080522.GB1389@katana> (raw)
In-Reply-To: <CADtm3G7ZHfVyoEcAcFGC4oPX=XHyedSWDMvg6nKPLQ5_is=ZiQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Sun, Feb 21, 2016 at 10:33:14PM -0800, Gregory Fong wrote:
> On Sun, Feb 21, 2016 at 6:16 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > We want the size of the struct, not of a pointer to it. To be future
> > proof, just dereference the pointer to get the desired type.
>
> This looks like it fixes like a fairly serious issue: before this
> change, the driver may modify memory that wasn't allocated for this
> struct. Shouldn't this also have Cc: stable?
Surely. I usually add the tag when committing, not when sending out.
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-22 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 14:16 [PATCH] i2c: brcmstb: allocate correct amount of memory for regmap Wolfram Sang
2016-02-22 6:33 ` Gregory Fong
2016-02-22 8:05 ` Wolfram Sang [this message]
2016-02-22 16:42 ` Florian Fainelli
2016-02-25 20:08 ` Kamal Dasu
2016-03-01 18:19 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2016-02-25 19:32 Kamal Dasu
2016-03-01 16:14 ` Kamal Dasu
2016-03-01 16:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222080522.GB1389@katana \
--to=wsa@the-dreams.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).