From: Wolfram Sang <wsa@the-dreams.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Christian Fetzer <fetzer.ch@gmail.com>
Subject: Re: [PATCH 2/3] i2c-piix4: Always use the same type for port
Date: Wed, 24 Feb 2016 11:40:33 +0100 [thread overview]
Message-ID: <20160224104033.GH1391@katana> (raw)
In-Reply-To: <20160129104530.1ba78e8b@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Fri, Jan 29, 2016 at 10:45:30AM +0100, Jean Delvare wrote:
> Sometimes u8 is used to store the port number, sometimes unsigned
> short is used. Consistently stick to a single type, for consistency
> and to avoid implicit casts.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Christian Fetzer <fetzer.ch@gmail.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-24 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 9:41 [PATCH 0/3] Improvements to the i2c-piix4 driver Jean Delvare
2016-01-29 9:44 ` [PATCH 1/3] i2c-piix4: Support alternative port selection register Jean Delvare
2016-01-29 10:59 ` Mika Westerberg
2016-01-29 12:04 ` Jean Delvare
2016-02-12 19:27 ` Wolfram Sang
2016-02-13 21:51 ` Jean Delvare
2016-02-14 8:39 ` fetzerch
2016-02-14 9:55 ` Jean Delvare
2016-02-15 17:30 ` Jean Delvare
2016-02-15 17:37 ` Wolfram Sang
2016-02-15 20:52 ` Jean Delvare
2016-01-29 9:45 ` [PATCH 2/3] i2c-piix4: Always use the same type for port Jean Delvare
2016-01-29 10:59 ` Mika Westerberg
2016-02-24 10:40 ` Wolfram Sang [this message]
2016-01-29 9:46 ` [PATCH 3/3] i2c-piix4: Pre-shift the port number Jean Delvare
2016-01-29 11:02 ` Mika Westerberg
2016-01-29 11:09 ` Jean Delvare
2016-02-24 10:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224104033.GH1391@katana \
--to=wsa@the-dreams.de \
--cc=fetzer.ch@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).