* spurious warning from of_i2c_register_device with fixed_regulator?
@ 2016-03-16 11:01 Pavel Machek
2016-03-16 11:20 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2016-03-16 11:01 UTC (permalink / raw)
To: pavel
Cc: wsa, linux-i2c, linux-kernel, pantelis.antoniou, grant.likely,
robh+dt
Hi!
We are getting this in the logs:
i2c i2c-0: of_i2c: invalid reg on /soc/i2c@ffc04000/vcc3p3-regulator
In the dts we have:
socfpga_cyclone5_sockit.dts:
regulator_3_3v: vcc3p3-regulator {
compatible = "regulator-fixed";
regulator-name = "VCC3P3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};
Which seems to trigger
drivers/i2c/i2c-core.c:
addr_be = of_get_property(node, "reg", &len);
if (!addr_be || (len < sizeof(*addr_be))) {
dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
...
But we have fixed regulator there, it does not have "reg" property.
Git blame says: a430a3455f2c48995e06b359a82a1109a419e9ef. (And no, I
don't have exactly mainline kernel here, but it should be close enough.)
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: spurious warning from of_i2c_register_device with fixed_regulator? 2016-03-16 11:01 spurious warning from of_i2c_register_device with fixed_regulator? Pavel Machek @ 2016-03-16 11:20 ` Wolfram Sang 2016-03-23 11:34 ` Pavel Machek 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2016-03-16 11:20 UTC (permalink / raw) To: Pavel Machek Cc: linux-i2c, linux-kernel, pantelis.antoniou, grant.likely, robh+dt [-- Attachment #1: Type: text/plain, Size: 200 bytes --] > But we have fixed regulator there, it does not have "reg" property. The fixed regulator doesn't even use I2C. So, you need to debug why it calls I2C. Your information given is not enough for me. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: spurious warning from of_i2c_register_device with fixed_regulator? 2016-03-16 11:20 ` Wolfram Sang @ 2016-03-23 11:34 ` Pavel Machek 0 siblings, 0 replies; 3+ messages in thread From: Pavel Machek @ 2016-03-23 11:34 UTC (permalink / raw) To: Wolfram Sang Cc: linux-i2c, linux-kernel, pantelis.antoniou, grant.likely, robh+dt Hi! > > But we have fixed regulator there, it does not have "reg" property. > > The fixed regulator doesn't even use I2C. So, you need to debug why it > calls I2C. Your information given is not enough for me. Thanks for the help. It seems to have been mismerge on my dts. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-23 11:34 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-16 11:01 spurious warning from of_i2c_register_device with fixed_regulator? Pavel Machek 2016-03-16 11:20 ` Wolfram Sang 2016-03-23 11:34 ` Pavel Machek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).