From: Wolfram Sang <wsa@the-dreams.de>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
CT kernel <linux-kernel@lists.codethink.co.uk>,
linux-i2c@vger.kernel.org
Subject: Re: [Linux-kernel] [PATCH] i2c: mux: demux-pinctrl: Fix reading the "master" attribute
Date: Wed, 30 Mar 2016 22:56:33 +0200 [thread overview]
Message-ID: <20160330205633.GA1386@katana> (raw)
In-Reply-To: <1459356327.27975.7.camel@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Wed, Mar 30, 2016 at 05:45:27PM +0100, Ben Hutchings wrote:
> On Wed, 2016-03-30 at 17:42 +0100, Ben Dooks wrote:
> > On 30/03/16 17:27, Ben Hutchings wrote:
> > > sysfs attributes should use the same format for reads and writes,
> > > rather than pretty-printing on read.
> > >
> > > Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver")
> > > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> >
> > should that be moved to a debugfs entry or a read-only sysfs?
>
> Probably another read-only attribute (like "scaling_governor" vs
> "scaling_available_governors" in cpufreq).
I agree. "current_master" and "available_masters" is probably the way to
go. Can you do it or shall I?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-30 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:27 [PATCH] i2c: mux: demux-pinctrl: Fix reading the "master" attribute Ben Hutchings
2016-03-30 16:42 ` [Linux-kernel] " Ben Dooks
2016-03-30 16:45 ` Ben Hutchings
2016-03-30 20:56 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330205633.GA1386@katana \
--to=wsa@the-dreams.de \
--cc=ben.dooks@codethink.co.uk \
--cc=ben.hutchings@codethink.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).