Re: [PATCH v2] i2c: efm32: Prevent potential division by zero

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hello Axel,

On Thu, Apr 14, 2016 at 10:17:45PM +0800, Axel Lin wrote:
> 2016-04-14 19:40 GMT+08:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > On Thu, Apr 14, 2016 at 05:49:35PM +0800, Axel Lin wrote:
> >> Make sure we don't OOPS in case clock-frequency is set to 0 in a DT. The
> >> variable set here is later used as a divisor.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> ---
> >> If my understand is correct, you prefer to make it return error rather
> >> than using default frequency setting if DT setting is wrong.
> >
> > No, I'd say it doesn't matter that the driver crashes if something
> > invalid is specified in the device tree. This is not a driver bug, but a
> > dt bug. So if it happens, fix the device tree, no need to modify the
> > driver.
> 
> I know that such case is a DT bug.
> But the intention of this patch is to avoid oops rather than fix dt.
> Make probe return error is enough to inform developer fixing dt.

an oops is also enough, and maybe even better because $developer cannot
miss it.

I don't care much, because the error probably won't happen. If you ask
me, I like your v2 better.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |