From: Wolfram Sang <wsa@the-dreams.de>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [RESEND PATCH v2 04/13] eeprom: at24: make locking more fine-grained
Date: Sat, 16 Apr 2016 22:56:55 +0200 [thread overview]
Message-ID: <20160416205655.GB1522@katana> (raw)
In-Reply-To: <1460401049-25459-5-git-send-email-bgolaszewski@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Mon, Apr 11, 2016 at 11:57:20AM -0700, Bartosz Golaszewski wrote:
> The only field in struct at24_data that needs locking in the module
> code is u8 *writebuf. Other data is already protected by i2c core.
>
> Rename the lock in at24_data to wrbuf_lock and only use it where
> writebuf is accessed.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Did you run some tests to verify our assumption?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-16 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 18:57 [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 01/13] eeprom: at24: remove a reduntant if Bartosz Golaszewski
2016-04-16 20:48 ` Wolfram Sang
2016-04-11 18:57 ` [RESEND PATCH v2 02/13] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 03/13] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 04/13] eeprom: at24: make locking more fine-grained Bartosz Golaszewski
2016-04-16 20:56 ` Wolfram Sang [this message]
2016-05-03 17:55 ` Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 05/13] eeprom: at24: replace msleep() with usleep_range() Bartosz Golaszewski
2016-04-16 20:58 ` Wolfram Sang
2016-04-11 18:57 ` [RESEND PATCH v2 06/13] eeprom: at24: add serial number flag Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 07/13] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 08/13] eeprom: at24: call read and write routines via function pointers Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 09/13] eeprom: at24: use at24cs_serial_read() Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 10/13] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 11/13] eeprom: at24: add at24mac series flag Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 12/13] eeprom: at24: add support for at24mac series Bartosz Golaszewski
2016-04-11 18:57 ` [RESEND PATCH v2 13/13] eeprom: at24: add at24mac chips to the list of supported devices Bartosz Golaszewski
2016-04-16 21:17 ` [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac Wolfram Sang
2016-04-20 14:38 ` Bartosz Golaszewski
2016-05-02 7:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416205655.GB1522@katana \
--to=wsa@the-dreams.de \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).