linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jean-Michel Hautbois <jhautbois@gmail.com>,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, galak@codeaurora.org,
	ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
	pawel.moll@arm.com, robh+dt@kernel.org, wsa@the-dreams.de,
	laurent.pinchart@ideasonboard.com,
	Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
Subject: Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses
Date: Tue, 19 Apr 2016 16:16:31 +0300	[thread overview]
Message-ID: <20160419131631.GG1725@lahna.fi.intel.com> (raw)
In-Reply-To: <57162C4E.9090904@metafoo.de>

On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote:
> On 04/19/2016 02:40 PM, Mika Westerberg wrote:
> > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote:
> >> A generic API by indexes wont work. The order between DT and ACPI will most
> >> likely be different. I'd even assume that the order will be different with
> >> ACPI for the same device on different platforms.
> > 
> > Yes, unfortunately that might be possible.
> > 
> >> If we want to support ACPI over the same interface drivers need to provide a
> >> lookup table that maps a name to the index.
> > 
> > Indeed something like we already have with GPIOs. The lookup table could
> > be filled from names in _DSD where it is available.
> 
> Does that mean you are OK with the patch as it is?

It is still not clear to me if this supports more than two addresses and
if it does, how those are represented in DT and how the function can be
used to fetch all those additional addresses.

  reply	other threads:[~2016-04-19 13:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 15:33 [PATCH v2] i2c: Add generic support passing secondary devices addresses Jean-Michel Hautbois
2016-02-01 14:46 ` Rob Herring
2016-03-24 10:11   ` Jean-Michel Hautbois
2016-03-24 14:02     ` Rob Herring
2016-04-14 19:10 ` Wolfram Sang
2016-04-15  8:01 ` Mika Westerberg
2016-04-18 15:20   ` Srinivas Pandruvada
     [not found]     ` <1460992811.8946.22.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-04-18 15:26       ` Lars-Peter Clausen
     [not found]         ` <5714FCBE.3060009-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-04-19 12:40           ` Mika Westerberg
2016-04-19 13:02             ` Lars-Peter Clausen
2016-04-19 13:16               ` Mika Westerberg [this message]
2016-04-19 13:31                 ` Lars-Peter Clausen
     [not found]                   ` <5716333D.1040106-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-04-19 14:40                     ` Mika Westerberg
2016-04-19 16:27                       ` Srinivas Pandruvada
     [not found]                       ` <20160419144027.GH1725-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-04-24 20:14                         ` Wolfram Sang
2016-04-25  7:25                           ` Mika Westerberg
2016-04-25  7:39                             ` Wolfram Sang
2016-04-25  7:41                               ` Mika Westerberg
2016-06-03  8:24                                 ` Lars-Peter Clausen
2016-04-19 13:49                 ` Wolfram Sang
2016-04-19 14:42                   ` Mika Westerberg
2016-06-05  6:15 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160419131631.GG1725@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jean-michel.hautbois@veo-labs.com \
    --cc=jhautbois@gmail.com \
    --cc=lars@metafoo.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).