* [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs
@ 2016-04-20 14:37 Javier Martinez Canillas
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-04-20 14:37 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-samsung-soc, Krzysztof Kozlowski,
Wolfram Sang, Kukjin Kim, linux-i2c, linux-arm-kernel
The driver not always prints the error code in case of a failure but this
information can be very useful for debugging. So let's print if available.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Hello,
This patch and 2/2 were only build tested because I don't have access to
a board using this IP block. I just noticed these issues when comparing
the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently.
I think the patches are simple enough that is safe to pick them but of
course testing will be highly appreciated.
Best regards,
Javier
Changes in v2:
- Don't print the errno code on probe since it's already printed by the
core. Suggested by Krzysztof Kozlowski.
drivers/i2c/busses/i2c-s3c2410.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 362a6de54833..13f67df65c45 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -944,7 +944,7 @@ static int s3c24xx_i2c_cpufreq_transition(struct notifier_block *nb,
i2c_unlock_adapter(&i2c->adap);
if (ret < 0)
- dev_err(i2c->dev, "cannot find frequency\n");
+ dev_err(i2c->dev, "cannot find frequency (%d)\n", ret);
else
dev_info(i2c->dev, "setting freq %d\n", got);
}
@@ -995,7 +995,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c)
ret = gpio_request(gpio, "i2c-bus");
if (ret) {
- dev_err(i2c->dev, "gpio [%d] request failed\n", gpio);
+ dev_err(i2c->dev, "gpio [%d] request failed (%d)\n",
+ gpio, ret);
goto free_gpio;
}
}
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
2016-04-20 14:37 [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
@ 2016-04-20 14:37 ` Javier Martinez Canillas
2016-04-21 7:19 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2016-04-21 7:18 ` [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2 siblings, 2 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-04-20 14:37 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-samsung-soc, Krzysztof Kozlowski,
Wolfram Sang, Kukjin Kim, linux-i2c, linux-arm-kernel
The clk_prepare_enable() function can fail so check the return
value and propagate the error in case of a failure.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Don't print the errno code since that's already printed by the
core when probe fails. Suggested by Krzysztof Kozlowski.
drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 13f67df65c45..8a9ea0c1e41d 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
/* initialise the i2c controller */
- clk_prepare_enable(i2c->clk);
+ ret = clk_prepare_enable(i2c->clk);
+ if (ret) {
+ dev_err(&pdev->dev, "I2C clock enable failed\n");
+ return ret;
+ }
+
ret = s3c24xx_i2c_init(i2c);
clk_disable(i2c->clk);
if (ret != 0) {
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
@ 2016-04-21 7:19 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-21 7:19 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-samsung-soc, Wolfram Sang, Kukjin Kim, linux-i2c,
linux-arm-kernel
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Don't print the errno code since that's already printed by the
> core when probe fails. Suggested by Krzysztof Kozlowski.
>
> drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
2016-04-21 7:19 ` Krzysztof Kozlowski
@ 2016-04-25 22:20 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-04-25 22:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, linux-samsung-soc, Krzysztof Kozlowski, Kukjin Kim,
linux-i2c, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Wed, Apr 20, 2016 at 10:37:56AM -0400, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs
2016-04-20 14:37 [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
@ 2016-04-21 7:18 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-21 7:18 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-samsung-soc, Wolfram Sang, Kukjin Kim, linux-i2c,
linux-arm-kernel
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The driver not always prints the error code in case of a failure but this
> information can be very useful for debugging. So let's print if available.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Hello,
>
> This patch and 2/2 were only build tested because I don't have access to
> a board using this IP block. I just noticed these issues when comparing
> the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently.
>
> I think the patches are simple enough that is safe to pick them but of
> course testing will be highly appreciated.
>
> Best regards,
> Javier
>
> Changes in v2:
> - Don't print the errno code on probe since it's already printed by the
> core. Suggested by Krzysztof Kozlowski.
>
> drivers/i2c/busses/i2c-s3c2410.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs
2016-04-20 14:37 [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
2016-04-21 7:18 ` [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski
@ 2016-04-25 22:20 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-04-25 22:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, linux-samsung-soc, Krzysztof Kozlowski, Kukjin Kim,
linux-i2c, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Wed, Apr 20, 2016 at 10:37:55AM -0400, Javier Martinez Canillas wrote:
> The driver not always prints the error code in case of a failure but this
> information can be very useful for debugging. So let's print if available.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-25 22:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 14:37 [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
2016-04-21 7:19 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2016-04-21 7:18 ` [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).