From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic Desroches Subject: Re: [PATCH] i2c: at91: change log when dma configuration fails Date: Fri, 13 May 2016 13:48:52 +0200 Message-ID: <20160513114852.GR27024@odux.rfo.atmel.com> References: <1463131331-6136-1-git-send-email-ludovic.desroches@atmel.com> <5735A405.3080008@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:5382 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbcEMLsv (ORCPT ); Fri, 13 May 2016 07:48:51 -0400 Content-Disposition: inline In-Reply-To: <5735A405.3080008@free.fr> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Mason Cc: Ludovic Desroches , wsa@the-dreams.de, linux-i2c@vger.kernel.org, nicolas.ferre@atmel.com On Fri, May 13, 2016 at 11:53:09AM +0200, Mason wrote: > On 13/05/2016 11:22, Ludovic Desroches wrote: > > > When the DMA configuration fails, there is a log reporting that we can't > > use DMA and indicating the error number. When booting the kernel, it is > > annoying to see this error number. Moreover, people can think something > > is going wrong. It is not the case, it means that DMA can't be used but > > it doesn't prevent to use i2c. > > > > Signed-off-by: Ludovic Desroches > > --- > > drivers/i2c/busses/i2c-at91.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > > index 921d32b..f2a7457 100644 > > --- a/drivers/i2c/busses/i2c-at91.c > > +++ b/drivers/i2c/busses/i2c-at91.c > > @@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr) > > > > error: > > if (ret != -EPROBE_DEFER) > > - dev_info(dev->dev, "can't use DMA, error %d\n", ret); > > + dev_info(dev->dev, > > + "can't request DMA channels, continue without DMA support\n", > > + ret); > > Did you forget to remove 'ret' after removing the %d format spec? > Oh yes, thanks. v2 is coming ! Regards