From: Wolfram Sang <wsa@the-dreams.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Seth Heasley <seth.heasley@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: i2c-i801 partially broken on Lynx Point PCH?
Date: Wed, 18 May 2016 15:02:53 +0200 [thread overview]
Message-ID: <20160518130253.GA1637@katana> (raw)
In-Reply-To: <20160518140508.7dfe192e@endymion>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
> 1* Remove I2C_FUNC_SMBUS_READ_I2C_BLOCK from the list of supported
> transactions whenever SPD write protection is enabled. In practice I
> think I2C Block Read is only useful for EEPROMs anyway, so I doubt
> anyone else will miss it. This is clearly a hack, but it's quite
> simple. Then the eeprom and at24 drivers will automatically fall
> back to slower read methods.
Doesn't feel very hackish to me. We skip a functionality which is known
to not work in this configuration. IIUC we might be able to get it to
work if we throw more code at it, but I don't like the extra complexity
in the I2C core for such a rare case.
Summary: My preferred solution so far :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-18 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 7:34 i2c-i801 partially broken on Lynx Point PCH? Jean Delvare
2016-05-11 8:43 ` Jean Delvare
2016-05-11 16:15 ` Heasley, Seth
2016-05-11 17:34 ` Jean Delvare
2016-05-11 17:46 ` Heasley, Seth
2016-05-18 12:05 ` Jean Delvare
2016-05-18 13:02 ` Wolfram Sang [this message]
2016-05-18 13:20 ` Jean Delvare
2016-05-19 11:02 ` Jarkko Nikula
2016-05-19 11:29 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518130253.GA1637@katana \
--to=wsa@the-dreams.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).