From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: I2C_RCAR should depend on HAS_DMA
Date: Sun, 22 May 2016 11:45:47 +0200 [thread overview]
Message-ID: <20160522094547.GQ29375@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1463902715-12680-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
On 2016-05-22 09:38:35 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `rcar_i2c_dma_unmap':
> i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
> drivers/built-in.o: In function `rcar_i2c_dma':
> i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
> i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 2dd40ddf04de3117..8ffb0d7015b0f4fe 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -985,6 +985,7 @@ config I2C_XLP9XX
>
> config I2C_RCAR
> tristate "Renesas R-Car I2C Controller"
> + depends on HAS_DMA
> depends on ARCH_RENESAS || COMPILE_TEST
> select I2C_SLAVE
> help
> --
> 1.9.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2016-05-22 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 7:38 [PATCH] i2c: I2C_RCAR should depend on HAS_DMA Geert Uytterhoeven
2016-05-22 9:45 ` Niklas Söderlund [this message]
2016-05-26 18:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522094547.GQ29375@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).