From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: [PATCH] i2c: i801: Drop needless bit-wise OR Date: Wed, 25 May 2016 09:37:02 +0200 Message-ID: <20160525093702.64d7309c@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:59704 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbcEYHhH (ORCPT ); Wed, 25 May 2016 03:37:07 -0400 Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Linux I2C Cc: Daniel Kurtz , Jarkko Nikula , Mika Westerberg , Wolfram Sang The interrupt handling code makes it look like several status values may be merged together before being processed, while this will never happen. Change from bit-wise OR to simple assignment to make it more obvious and avoid misunderstanding. Signed-off-by: Jean Delvare Cc: Daniel Kurtz Cc: Jarkko Nikula Cc: Mika Westerberg Cc: Wolfram Sang --- Daniel, was there any reason for this bit-wise OR, which I may be missing? drivers/i2c/busses/i2c-i801.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-4.5.orig/drivers/i2c/busses/i2c-i801.c 2016-05-24 11:04:33.169026906 +0200 +++ linux-4.5/drivers/i2c/busses/i2c-i801.c 2016-05-24 11:05:40.564642488 +0200 @@ -548,7 +548,7 @@ static irqreturn_t i801_isr(int irq, voi status &= SMBHSTSTS_INTR | STATUS_ERROR_FLAGS; if (status) { outb_p(status, SMBHSTSTS(priv)); - priv->status |= status; + priv->status = status; wake_up(&priv->waitq); } -- Jean Delvare SUSE L3 Support