From: Jean Delvare <jdelvare@suse.de>
To: minyard@acm.org
Cc: linux-i2c@vger.kernel.org, Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH 5/5] i2c-i801: Remove redundant code and event-drive
Date: Wed, 25 May 2016 14:52:30 +0200 [thread overview]
Message-ID: <20160525145230.24f1c881@endymion> (raw)
In-Reply-To: <1453223377-20608-6-git-send-email-minyard@acm.org>
Hi Corey,
On Tue, 19 Jan 2016 11:09:37 -0600, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> There was a lot of redundant code in the driver, basically one copy
> for the polled interface and one for the interrupt-driven interface.
> Only use the interrupt-driven interface and use a timer to check
> the interface periodically and time things out.
This patch is simply too large and messy for me to consider reviewing
it. It needs to be split into smaller pieces. But honestly I don't see
that much redundancy in the driver, and as a matter of fact your patch
adds more lines than it removes.
This is unfortunate because some of the changes would still be good to
have. In particular having a single call to i801_check_post() would be
a nice clean-up.
> This also adds timeouts when using interrupt, so a failed operation
> won't hang forever.
As far as I can see, the current code already has these timeouts,
although maybe it wasn't the case when you first wrote this patch? This
was added by b3b8df9772 in November 2014.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-05-25 12:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 17:09 [PATCH 0/5] minyard
2016-01-19 17:09 ` [PATCH 1/5] i2c-i801: hwpec and check_pre cleanups minyard
2016-05-25 9:30 ` Jean Delvare
2016-05-25 11:04 ` Jean Delvare
2016-01-19 17:09 ` [PATCH 2/5] i2c-i801: Move hostcfg set/reset to i801_access() minyard
2016-05-25 11:42 ` Jean Delvare
2016-01-19 17:09 ` [PATCH 3/5] i2c-i801: Move PEC handling into i2c_block_transaction() minyard
2016-05-25 12:00 ` Jean Delvare
2016-01-19 17:09 ` [PATCH 4/5] i2c-i801: clean up block transaction minyard
2016-05-25 12:31 ` Jean Delvare
2016-01-19 17:09 ` [PATCH 5/5] i2c-i801: Remove redundant code and event-drive minyard
2016-05-25 12:52 ` Jean Delvare [this message]
2016-05-25 16:58 ` Corey Minyard
2016-05-26 7:17 ` Jean Delvare
2016-05-26 12:15 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525145230.24f1c881@endymion \
--to=jdelvare@suse.de \
--cc=cminyard@mvista.com \
--cc=linux-i2c@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).