From: Wolfram Sang <wsa@the-dreams.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Erico Nunes <erico.nunes@datacom.ind.br>,
kernel-janitors@vger.kernel.org, LKP <lkp@01.org>
Subject: Re: [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API"
Date: Sat, 28 May 2016 18:04:58 +0200 [thread overview]
Message-ID: <20160528160458.GA1614@katana> (raw)
In-Reply-To: <20160528091559.GR11011@mwanda>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
> These kinds of use after frees don't always cause a runtime problem. I
> found it using static analysis, but I bet you could detect it if you
> enabled kasan. The other option is to enable PAGE_POISONING?
Thanks, PAGE_POISONING did trigger the issue. So, I now picked up your
patch instead of the revert because I could verify the problem and the
proper solution. Thanks again.
What I still wonder: Which analysis reported the problem to you? I
always run sparse, smatch, cppcheck, and coccicheck on the patches when
applying and no-one reported the issue.
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-28 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 9:07 [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API" Wolfram Sang
2016-05-28 9:15 ` Dan Carpenter
2016-05-28 16:04 ` Wolfram Sang [this message]
2016-05-30 7:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528160458.GA1614@katana \
--to=wsa@the-dreams.de \
--cc=dan.carpenter@oracle.com \
--cc=erico.nunes@datacom.ind.br \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).