From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Weifeng Voon <weifeng.voon@intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
jui.nee.tan@intel.com
Subject: Re: [PATCH] i2c: designware: Enable ioctl I2C_TIMEOUT
Date: Thu, 2 Jun 2016 10:33:30 +0200 [thread overview]
Message-ID: <20160602083330.GY26768@pengutronix.de> (raw)
In-Reply-To: <1464854250-6810-1-git-send-email-weifeng.voon@intel.com>
On Thu, Jun 02, 2016 at 03:57:30PM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.
10ms is only correct with HZ=100. With higher values of HZ you get a
finer resolution. I'd write:
Respect the transfer timeout set via the I2C_TIMEOUT ioctl.
and not mention the resolution at all. After all your patch doesn't
"enable" that ioctl, just makes use of the value set by it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-06-02 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 7:57 [PATCH] i2c: designware: Enable ioctl I2C_TIMEOUT Weifeng Voon
2016-06-02 8:33 ` Uwe Kleine-König [this message]
2016-06-02 9:11 ` Voon, Weifeng
2016-06-09 20:50 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602083330.GY26768@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jui.nee.tan@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weifeng.voon@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).