From: Andrew Lunn <andrew@lunn.ch>
To: Axel Lin <axel.lin@ingics.com>
Cc: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: robotfuzz-osif: Constify osif_table
Date: Thu, 2 Jun 2016 13:59:57 +0200 [thread overview]
Message-ID: <20160602115957.GE17343@lunn.ch> (raw)
In-Reply-To: <1464845328.6532.1.camel@ingics.com>
On Thu, Jun 02, 2016 at 01:28:48PM +0800, Axel Lin wrote:
> osif_table is never modified, so declare it as const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/i2c/busses/i2c-robotfuzz-osif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-robotfuzz-osif.c b/drivers/i2c/busses/i2c-robotfuzz-osif.c
> index ced9c6a..89d8b41 100644
> --- a/drivers/i2c/busses/i2c-robotfuzz-osif.c
> +++ b/drivers/i2c/busses/i2c-robotfuzz-osif.c
> @@ -125,7 +125,7 @@ static struct i2c_algorithm osif_algorithm = {
> #define USB_OSIF_VENDOR_ID 0x1964
> #define USB_OSIF_PRODUCT_ID 0x0001
>
> -static struct usb_device_id osif_table[] = {
> +static const struct usb_device_id osif_table[] = {
> { USB_DEVICE(USB_OSIF_VENDOR_ID, USB_OSIF_PRODUCT_ID) },
> { }
> };
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-06-02 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 5:28 [PATCH] i2c: robotfuzz-osif: Constify osif_table Axel Lin
2016-06-02 11:59 ` Andrew Lunn [this message]
2016-06-09 20:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602115957.GE17343@lunn.ch \
--to=andrew@lunn.ch \
--cc=axel.lin@ingics.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).