From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andy Lutomirski <luto@kernel.org>,
Mario Limonciello <mario_limonciello@dell.com>,
pali.rohar@gmail.com, Matt Fleming <matt@codeblueprint.co.uk>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Date: Thu, 9 Jun 2016 11:15:46 +0300 [thread overview]
Message-ID: <20160609081546.GA1791@lahna.fi.intel.com> (raw)
In-Reply-To: <20160608162913.GA24234@mail.corp.redhat.com>
On Wed, Jun 08, 2016 at 06:29:13PM +0200, Benjamin Tissoires wrote:
> > - err = acpi_check_resource_conflict(&dev->resource[SMBBAR]);
> > - if (err) {
> > + err = i801_acpi_probe(priv);
> > + if (err)
> > return -ENODEV;
> > - }
>
> I'd say that once this has been set, we need to call
> acpi_remove_address_space_handler() in case of failure later (in the 2
> returns after).
Indeed - I wonder how many mistakes one patch can contain :-(
Let me fix this and submit yet another version.
> The rest looks OK to me.
Thanks!
next prev parent reply other threads:[~2016-06-09 8:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 8:04 [PATCH v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR Mika Westerberg
2016-06-08 16:29 ` [v5] " Benjamin Tissoires
2016-06-09 8:15 ` Mika Westerberg [this message]
2016-06-13 9:19 ` Jean Delvare
2016-06-13 9:45 ` Pali Rohár
2016-06-13 9:46 ` Mika Westerberg
2016-06-13 9:48 ` Pali Rohár
2016-06-13 9:54 ` Mika Westerberg
2016-06-24 14:12 ` Jean Delvare
2016-06-29 7:56 ` Pali Rohár
2016-06-29 10:39 ` Mika Westerberg
2016-07-04 8:22 ` Jean Delvare
2016-07-04 14:30 ` Pali Rohár
2016-07-05 10:14 ` Mika Westerberg
2016-07-05 11:30 ` Pali Rohár
2016-07-05 11:51 ` Mika Westerberg
2016-07-05 11:56 ` Pali Rohár
2016-07-05 12:00 ` Pali Rohár
2016-07-05 14:31 ` Mika Westerberg
2016-07-24 10:08 ` Martin Vajnar
2016-07-25 10:19 ` Pali Rohár
2016-07-14 11:52 ` Pali Rohár
2016-07-14 14:20 ` Rafael J. Wysocki
2016-07-25 10:22 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609081546.GA1791@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=matt@codeblueprint.co.uk \
--cc=pali.rohar@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).