From: Wolfram Sang <wsa@the-dreams.de>
To: Sricharan <sricharan@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org,
agross@codeaurora.org, linux-kernel@vger.kernel.org,
nkaje@codeaurora.org, absahu@codeaurora.org,
linux-i2c@vger.kernel.org, galak@codeaurora.org,
andy.gross@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled
Date: Thu, 9 Jun 2016 22:46:55 +0200 [thread overview]
Message-ID: <20160609204655.GN23522@katana> (raw)
In-Reply-To: <002201d1b79a$22862bc0$67928340$@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
> The coherency is not dropped here. dma_map/unmap used
> makes the buffer coherent before passing it to
> dmaengine. Previously it was not required.
> I can add this in description if its not clear.
Please do.
>
> >> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >> }
> >> }
> >>
> >> + idx = 0;
> >> +
> >
> >This looks like an unrelated change.
> Ha, wrong. This should have been in a separate patch.
Exactly this is what I meant with "unrelated" :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-09 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 8:16 [PATCH V3 0/2] i2c: qup: Some misc fixes Sricharan R
2016-05-25 8:16 ` [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled Sricharan R
2016-05-26 18:48 ` Wolfram Sang
2016-05-26 22:01 ` Sricharan
2016-06-09 20:46 ` Wolfram Sang [this message]
2016-05-25 8:16 ` [PATCH V3 2/2] i2c: qup: Fix error handling Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609204655.GN23522@katana \
--to=wsa@the-dreams.de \
--cc=absahu@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=ntelkar@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).