From: Wolfram Sang <wsa@the-dreams.de>
To: Crestez Dan Leonard <leonard.crestez@intel.com>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-i2c@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org,
Irina Tirdea <irina.tirdea@intel.com>,
Octavian Purdila <octavian.purdila@intel.com>,
Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT ids through ACPI
Date: Fri, 10 Jun 2016 15:07:06 +0200 [thread overview]
Message-ID: <20160610130706.GA1624@katana> (raw)
In-Reply-To: <bb2702c4-848a-4e0e-6381-66af079a7c13@intel.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
> Looking at that series it seems that the intention is to eventually
> remove the i2c_device_id argument from probe completely? That would
> cause a lot of code churn. It would also require every driver that needs
> to differentiate between models to pretty much duplicate the matching
> logic performed by the core.
I am with you on the "duplicated matching" issue which I personally
don't like at all.
That being said, it is the de-facto standard way of doing it currently.
If this is going to be changed, it should be done on a BIG SCALE.
Currently, I2C has a special way of passing matches. Because I see more
important topics to work on, I personally could leave it as is. But if
people want I2C to behave as the rest of the kernel, this is fine with
me if they are committed to do it 100%. Replacing the current I2C
special way with another I2C special way is no option. The correct path
IMO is to bring I2C in line with the rest of the kernel and fix the
kernel.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-10 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 13:06 [RFC v2 0/2] Match i2c_device_id when using DT ids through ACPI Crestez Dan Leonard
2016-06-09 13:06 ` [RFC v2 1/2] acpi: Expose acpi_of_match_device Crestez Dan Leonard
2016-06-09 13:06 ` [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT ids through ACPI Crestez Dan Leonard
2016-06-10 6:32 ` Mika Westerberg
2016-06-10 15:57 ` Crestez Dan Leonard
2016-06-13 9:26 ` Mika Westerberg
2016-06-10 7:04 ` Wolfram Sang
2016-06-10 12:00 ` Crestez Dan Leonard
2016-06-10 13:07 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-01 6:14 Phong Vo
2016-12-06 17:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610130706.GA1624@katana \
--to=wsa@the-dreams.de \
--cc=daniel.baluta@intel.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=leonard.crestez@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).