From: Lee Jones <lee.jones@linaro.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG
Date: Thu, 16 Jun 2016 11:39:37 +0100 [thread overview]
Message-ID: <20160616103937.GT4948@dell> (raw)
In-Reply-To: <57617A1D.3050502@ti.com>
On Wed, 15 Jun 2016, Andrew F. Davis wrote:
> On 06/15/2016 10:43 AM, Lee Jones wrote:
> > This requires a USB Ack.
> >
> >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter.
> >> Add MFD core support.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> >
> > Where is the change log from v1 => v2?
> >
>
> Looking at a diff of the two it looks like all the changes are related
> to your v1 feedback:
>
> - Rename sm-usb-dig -> ti-smusbdig
> - Inline helper functions in header
> - Alphabetize includes
Please ensure this is added when you submit subsequent sets. It
really does help with the review and saves a great deal of time.
> >> Changes from v2:
> >> - Add missing dependency on USB, thanks kbuild test robot
> >>
> >> drivers/mfd/Kconfig | 9 +++
> >> drivers/mfd/Makefile | 2 +
> >> drivers/mfd/ti-smusbdig.c | 138 ++++++++++++++++++++++++++++++++++++++++
> >> include/linux/mfd/ti-smusbdig.h | 75 ++++++++++++++++++++++
> >> 4 files changed, 224 insertions(+)
> >> create mode 100644 drivers/mfd/ti-smusbdig.c
> >> create mode 100644 include/linux/mfd/ti-smusbdig.h
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-06-16 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 15:07 [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG Andrew F. Davis
2016-06-13 15:08 ` [PATCH v3 2/2] i2c: ti-smusbdig: add TI SM-USB-DIG I2C bus driver Andrew F. Davis
2016-06-15 15:43 ` [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG Lee Jones
2016-06-15 15:54 ` Andrew F. Davis
2016-06-16 10:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616103937.GT4948@dell \
--to=lee.jones@linaro.org \
--cc=afd@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).