From: Jean Delvare <jdelvare@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
Date: Thu, 16 Jun 2016 11:49:15 +0200 [thread overview]
Message-ID: <20160616114915.0446f3a3@endymion> (raw)
In-Reply-To: <1465996923-76230-1-git-send-email-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote:
> The IP seems not used outside of x86 world, so, make it depend on CONFIG_X86.
I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH
mainboard.) So, nack, sorry. However I'd be OK with:
depends on X86 || IA64 || COMPILE_TEST
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/Kconfig | 4 ++--
> drivers/i2c/busses/i2c-i801.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index f167021..78609ad 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -89,8 +89,8 @@ config I2C_HIX5HD2
>
> config I2C_I801
> tristate "Intel 82801 (ICH/PCH)"
> - depends on PCI
> - select CHECK_SIGNATURE if X86 && DMI
> + depends on X86 && PCI
> + select CHECK_SIGNATURE if DMI
> help
> If you say yes to this option, support will be included
> for the Intel 801 family of mainboard I2C interfaces. Specifically,
> the following diff --git a/drivers/i2c/busses/i2c-i801.c
> b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = {
>
> MODULE_DEVICE_TABLE(pci, i801_ids);
>
> -#if defined CONFIG_X86 && defined CONFIG_DMI
> +#ifdef CONFIG_DMI
> static unsigned char apanel_addr;
>
> /* Scan the system ROM for the signature "FJKEYINF" */
> @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct
> i801_priv *priv) #else
> static void __init input_apanel_init(void) {}
> static void i801_probe_optional_slaves(struct i801_priv *priv) {}
> -#endif /* CONFIG_X86 && CONFIG_DMI */
> +#endif /* CONFIG_DMI */
>
> #if (defined CONFIG_I2C_MUX_GPIO || defined
> CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-06-16 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 13:22 [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86 Andy Shevchenko
2016-06-16 9:49 ` Jean Delvare [this message]
2016-06-17 9:31 ` Andy Shevchenko
2016-06-17 18:59 ` Jean Delvare
2016-06-17 19:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616114915.0446f3a3@endymion \
--to=jdelvare@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).