* [PATCH] i2c: elektor: Utilize the module_isa_driver macro
@ 2016-05-31 15:37 William Breathitt Gray
2016-06-19 17:46 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: William Breathitt Gray @ 2016-05-31 15:37 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, linux-kernel
This driver does not do anything special in module init/exit. This patch
eliminates the module init/exit boilerplate code by utilizing the
module_isa_driver macro.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/i2c/busses/i2c-elektor.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-elektor.c b/drivers/i2c/busses/i2c-elektor.c
index 92e8c0c..aa0cc5c 100644
--- a/drivers/i2c/busses/i2c-elektor.c
+++ b/drivers/i2c/busses/i2c-elektor.c
@@ -319,16 +319,6 @@ static struct isa_driver i2c_elektor_driver = {
},
};
-static int __init i2c_pcfisa_init(void)
-{
- return isa_register_driver(&i2c_elektor_driver, 1);
-}
-
-static void __exit i2c_pcfisa_exit(void)
-{
- isa_unregister_driver(&i2c_elektor_driver);
-}
-
MODULE_AUTHOR("Hans Berglund <hb@spacetec.no>");
MODULE_DESCRIPTION("I2C-Bus adapter routines for PCF8584 ISA bus adapter");
MODULE_LICENSE("GPL");
@@ -339,5 +329,4 @@ module_param(clock, int, 0);
module_param(own, int, 0);
module_param(mmapped, int, 0);
-module_init(i2c_pcfisa_init);
-module_exit(i2c_pcfisa_exit);
+module_isa_driver(i2c_elektor_driver, 1);
--
2.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: elektor: Utilize the module_isa_driver macro
2016-05-31 15:37 [PATCH] i2c: elektor: Utilize the module_isa_driver macro William Breathitt Gray
@ 2016-06-19 17:46 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2016-06-19 17:46 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
On Tue, May 31, 2016 at 11:37:13AM -0400, William Breathitt Gray wrote:
> This driver does not do anything special in module init/exit. This patch
> eliminates the module init/exit boilerplate code by utilizing the
> module_isa_driver macro.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-19 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 15:37 [PATCH] i2c: elektor: Utilize the module_isa_driver macro William Breathitt Gray
2016-06-19 17:46 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).