From: Wolfram Sang <wsa@the-dreams.de>
To: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: Question about I2C driver upstream from same SoC vendor
Date: Tue, 21 Jun 2016 12:59:54 +0200 [thread overview]
Message-ID: <20160621105954.GA2263@katana> (raw)
In-Reply-To: <CAOAejn0EaPQK7A-YAN1RC6dVEB5wxtVvWq9Z0D0GnA66N9GoVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Hi Cedric,
> I am wondering if it is the good way of working as I noticed that many
> maintainers prefer to have one driver that support all IPs of the same
> SoC vendor ?
Really? That doesn't sound too healthy to me...
> In our case, I think it will be possible to support both I2C IPs in
> one driver called i2c-stm32.c but the code will run of readability and
> will be difficult to maintain...
I think a driver should handle the same or similar IP cores. Quite the
contrary, the same IP cores can be found in SoCs from different vendors.
They should then *still* be handled by the same driver. I usually
compare register sets to decide which way to go.
For your case, this sounds pretty much like a second driver. Good you
asked beforehand.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-21 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 7:59 Question about I2C driver upstream from same SoC vendor M'boumba Cedric Madianga
2016-06-21 10:59 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621105954.GA2263@katana \
--to=wsa@the-dreams.de \
--cc=cedric.madianga@gmail.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).