From: Jean Delvare <jdelvare@suse.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Andy Lutomirski" <luto@kernel.org>,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Date: Fri, 24 Jun 2016 16:12:38 +0200 [thread overview]
Message-ID: <20160624161238.0fc748ad@endymion> (raw)
In-Reply-To: <20160613095404.GH1791@lahna.fi.intel.com>
Hi Mika,
On Mon, 13 Jun 2016 12:54:04 +0300, Mika Westerberg wrote:
> On Mon, Jun 13, 2016 at 11:48:30AM +0200, Pali Rohár wrote:
> > I mean to call acpi_remove_address_space_handler() in
> > i801_acpi_io_handler() after acpi_reserved is properly set.
> >
> > As once acpi_reserved is set address space handler is not needed
> > anymore.
>
> It is still needed as we handle all AML OpRegion access in this driver
> from that point forward. Unless I'm missing something.
I think Pali is correct. The only purpose of handling the region is to
detect that it is being accessed so we can set priv->acpi_reserved.
Once it is set, i801_acpi_io_handler becomes transparent: it forwards
the requests without doing anything with them. The very same would
happen if we would unregister the handler at that point, but without the
extra overhead.
So while the current code does work fine, unregistering the handler
when we set priv->acpi_reserved would be more optimal.
Unless both Pali and myself are missing something, that is.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-06-24 14:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 8:04 [PATCH v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR Mika Westerberg
2016-06-08 16:29 ` [v5] " Benjamin Tissoires
2016-06-09 8:15 ` Mika Westerberg
2016-06-13 9:19 ` Jean Delvare
2016-06-13 9:45 ` Pali Rohár
2016-06-13 9:46 ` Mika Westerberg
2016-06-13 9:48 ` Pali Rohár
2016-06-13 9:54 ` Mika Westerberg
2016-06-24 14:12 ` Jean Delvare [this message]
2016-06-29 7:56 ` Pali Rohár
2016-06-29 10:39 ` Mika Westerberg
2016-07-04 8:22 ` Jean Delvare
2016-07-04 14:30 ` Pali Rohár
2016-07-05 10:14 ` Mika Westerberg
2016-07-05 11:30 ` Pali Rohár
2016-07-05 11:51 ` Mika Westerberg
2016-07-05 11:56 ` Pali Rohár
2016-07-05 12:00 ` Pali Rohár
2016-07-05 14:31 ` Mika Westerberg
2016-07-24 10:08 ` Martin Vajnar
2016-07-25 10:19 ` Pali Rohár
2016-07-14 11:52 ` Pali Rohár
2016-07-14 14:20 ` Rafael J. Wysocki
2016-07-25 10:22 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624161238.0fc748ad@endymion \
--to=jdelvare@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=matt@codeblueprint.co.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=pali.rohar@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).