From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ellen Wang <ellen@cumulusnetworks.com>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 i2c/for-next] i2c: i801: recover from hardware PEC errors
Date: Fri, 1 Jul 2016 11:30:28 +0200 [thread overview]
Message-ID: <20160701113028.7a47c236@endymion> (raw)
In-Reply-To: <20150709165939.GB4744@katana>
Hi Wolfram, Ellen,
On Thu, 9 Jul 2015 18:59:39 +0200, Wolfram Sang wrote:
> On Fri, May 22, 2015 at 03:14:28PM -0700, Ellen Wang wrote:
> > On a CRC error while using hardware-supported PEC, an additional
> > error bit is set in the auxiliary status register. If this bit
> > isn't cleared, all subsequent operations will fail, essentially
> > hanging the controller.
> >
> > The fix is simple: check, report, and clear the bit in
> > i801_check_post(). Also, in case the driver starts with the
> > hardware in that state, clear it in i801_check_pre() as well.
> >
> > Signed-off-by: Ellen Wang <ellen@cumulusnetworks.com>
> > ---
> > Update: fix typos in commit message, otherwise the same as v2
> >
> > This is essentially the patch from Jean Delvare, which handles
> > the polling case while my original version didn't. (Thank you!
> > Please add appropriate attribution if you wish.)
> >
> > I tested all the additional code paths by selectively commenting
> > out code: with interrupts, without interrupts, relying on check_pre()
> > to clear CRCE, no clearing of CRCE at all (baseline).
>
> Jean, any comments or tags to add?
Sorry, this one fell trough the cracks. The patch is good and still
needed. I have tested it successfully on several systems. Wolfram,
please apply it.
Tested-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-07-01 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 22:14 [PATCH v3 i2c/for-next] i2c: i801: recover from hardware PEC errors Ellen Wang
[not found] ` <1432332868-12705-1-git-send-email-ellen-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2015-07-09 16:59 ` Wolfram Sang
2016-07-01 9:30 ` Jean Delvare [this message]
2016-07-01 15:49 ` Wolfram Sang
2016-07-01 18:18 ` Jean Delvare
2016-07-01 21:13 ` Wolfram Sang
2016-07-01 21:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701113028.7a47c236@endymion \
--to=jdelvare@suse.de \
--cc=ellen@cumulusnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).