From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pali =?utf-8?q?Roh=C3=A1r?= <pali.rohar@gmail.com>
Subject: Re: [v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Date: Tue, 5 Jul 2016 13:56:58 +0200
Message-ID: <201607051356.58794@pali>
References: <1463990658-53854-1-git-send-email-mika.westerberg@linux.intel.com> <201607051330.23650@pali> <20160705115142.GO23527@lahna.fi.intel.com>
Mime-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart4802767.USD8Fa594k";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Return-path: <linux-acpi-owner@vger.kernel.org>
In-Reply-To: <20160705115142.GO23527@lahna.fi.intel.com>
Sender: linux-acpi-owner@vger.kernel.org
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jean Delvare <jdelvare@suse.de>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Wolfram Sang <wsa@the-dreams.de>, Jarkko Nikula <jarkko.nikula@linux.intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Andy Lutomirski <luto@kernel.org>, Mario Limonciello <mario_limonciello@dell.com>, Matt Fleming <matt@codeblueprint.co.uk>, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
List-Id: linux-i2c@vger.kernel.org

--nextPart4802767.USD8Fa594k
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Tuesday 05 July 2016 13:51:42 Mika Westerberg wrote:
> On Tue, Jul 05, 2016 at 01:30:23PM +0200, Pali Roh=C3=A1r wrote:
> > On Tuesday 05 July 2016 12:14:55 Mika Westerberg wrote:
> > > The whole point of this patch is that we expect that nobody never
> > > uses that OpRegion. I'm 99% sure you don't find a single machine
> > > where it is actually in use.
> >=20
> > HP EliteBook 8460p uses it for sure! Here are DSDT snips:
> >                 Method (\_SB.PCI0.LPCB.SMAB, 3, Serialized)
> >                 {
> >                =20
> >                     If (LEqual (And (Arg0, 0x01), 0x00))
> >                     {
> >                    =20
> >                         Store (0x01, Local0)
> >                         Store (\_SB.PCI0.SBUS.SWRB (Arg0, Arg1,
> >                         Arg2), Local1) If (Local1)
> >                         {
> >                        =20
> >                             Store (0x00, Local0)
> >                        =20
> >                         }
> >                    =20
> >                     }
> >                     Else
> >                     {
> >                    =20
> >                         Store (\_SB.PCI0.SBUS.SRDB (Arg0, Arg1),
> >                         Local0)
> >                    =20
> >                     }
> >                    =20
> >                     Return (Local0)
> >                =20
> >                 }
>=20
> Crap, well that is in that 1% then ;-)

I bet that every HP notebook with accelerometer which is used by=20
hp_accel.ko driver is affected by this problem. And then it will be more=20
then 1% :-)

> > ...
> >=20
> >                 Method (ALRD, 1, Serialized)
> >                 {
> >                =20
> >                     Store (\_SB.PCI0.LPCB.SMAB (0x33, Arg0, 0x00),
> >                     Local0) Return (Local0)
> >                =20
> >                 }
> >                =20
> >                 Method (ALWR, 2, Serialized)
> >                 {
> >                =20
> >                     Store (\_SB.PCI0.LPCB.SMAB (0x32, Arg0, Arg1),
> >                     Local0) Return (Local0)
> >                =20
> >                 }
> >=20
> > And ALRD and ALWR methods are used by hp_accel.ko kernel driver.
>=20
> So are you able to test what happens when you unload the driver?

As I wrote in previous email, I do not own these EliteBooks anymore, so=20
cannot test it. Just have DSDT dump...

=2D-=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--nextPart4802767.USD8Fa594k
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAld7oIoACgkQi/DJPQPkQ1LeCgCfUB3P+RSboG4BrVYq1yf/Nm7W
6L8An2zyEmqxBQOh69oiiIvQH/EtbNqo
=Gj2g
-----END PGP SIGNATURE-----

--nextPart4802767.USD8Fa594k--