From: Viresh Kumar <viresh.kumar@linaro.org>
To: Peter Rosin <peda@axentia.se>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Wolfram Sang <wsa@the-dreams.de>,
Jean Delvare <jdelvare@suse.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, Johan Hovold <johan@kernel.org>,
Alex Elder <elder@linaro.org>
Subject: Re: [PATCH 2/2] i2c-dev: Don't block the adapter from unregistering
Date: Wed, 6 Jul 2016 08:37:03 -0700 [thread overview]
Message-ID: <20160706153703.GN2671@ubuntu> (raw)
In-Reply-To: <a65124df-0d47-41a8-b90f-0d6e3fd9ce4f@axentia.se>
On 06-07-16, 17:04, Peter Rosin wrote:
> Exactly, so the stored address had better be correct, and in
No.
> that case there is no need for the new adapter_nr in every
> client, you could just go with client->adapter->nr instead.
client->adapter may be a dangling pointer at this point if the adapter
is freed, so we can't use that blindly for sure.
> Which just shows that the whole thing is fishy and that the
> adapter has to remain alive. BTW, is there any guarantee that
> adapter numbers will not get reused?
We are allocating them from idr and that will reuse them once they get
freed.
--
viresh
next prev parent reply other threads:[~2016-07-06 15:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 2:57 [PATCH 0/2] i2c-dev: Don't let userspace block adapter Viresh Kumar
2016-07-06 2:57 ` [PATCH 1/2] i2c-dev: don't get i2c adapter via i2c_dev Viresh Kumar
2016-07-06 17:04 ` Jean Delvare
2016-07-06 17:07 ` Viresh Kumar
2016-07-07 13:16 ` Jean Delvare
2016-07-07 15:35 ` Viresh Kumar
2016-07-08 1:31 ` Wolfram Sang
2016-07-06 2:57 ` [PATCH 2/2] i2c-dev: Don't block the adapter from unregistering Viresh Kumar
2016-07-06 4:32 ` kbuild test robot
2016-07-06 6:55 ` Wolfram Sang
2016-07-06 13:50 ` Viresh Kumar
2016-07-06 17:12 ` Jean Delvare
2016-07-06 20:55 ` Viresh Kumar
2016-07-11 12:22 ` Jean Delvare
2016-07-11 21:50 ` Greg KH
2016-07-18 20:20 ` Viresh Kumar
2016-07-25 9:39 ` Jean Delvare
2016-07-25 22:31 ` Viresh Kumar
2016-07-26 7:41 ` Jean Delvare
2016-07-26 15:18 ` Dmitry Torokhov
2016-07-06 8:22 ` Peter Rosin
2016-07-06 14:33 ` Viresh Kumar
2016-07-06 14:43 ` Lars-Peter Clausen
2016-07-06 15:04 ` Peter Rosin
2016-07-06 15:37 ` Viresh Kumar [this message]
2016-07-06 15:35 ` Viresh Kumar
2016-07-06 14:41 ` [PATCH 0/2] i2c-dev: Don't let userspace block adapter Lars-Peter Clausen
2016-07-06 15:34 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706153703.GN2671@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=johan@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).